src/Appwrite/Platform/Workers/StatsUsage.php (2)

21-26: LGTM! Consider adding documentation for extension points.

The visibility changes enable subclassing and extension of this worker class, which aligns with the PR objective. The pattern is consistent with other workers in the codebase (e.g., Audits.php).

However, consider adding PHPDoc comments to document:

• Which properties are safe for subclasses to access or modify
• Any constraints or invariants that subclasses should maintain
• Whether direct property modification is intended or if accessor methods should be added in the future

This will help prevent subclasses from inadvertently breaking internal state consistency.

Also applies to: 32-32, 38-38

---

198-362: LGTM! Consider future refactoring for better extensibility.

Changing reduce() to protected enables subclasses to customize metric reduction logic, which aligns with the extensibility goal.

As an optional future improvement, consider refactoring this method to use a strategy pattern or template method pattern with smaller, overridable methods for each document type case. This would allow subclasses to extend specific reduction behaviors without overriding the entire method, reducing the risk of breaking core functionality.

For example:

protected function reduce(Document $project, Document $document, array &$metrics, callable $getProjectDB): void
{
    $collection = $document->getCollection();
    
    switch (true) {
        case $collection === 'users':
            $this->reduceUsers($project, $document, $metrics, $getProjectDB);
            break;
        case $collection === 'databases':
            $this->reduceDatabases($project, $document, $metrics, $getProjectDB);
            break;
        // ... other cases
    }
}

protected function reduceUsers(Document $project, Document $document, array &$metrics, callable $getProjectDB): void
{
    // Current users case logic
}

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro