Skip to content

Update .NET SDK to 0.21.2 and improve release detection#10641

Merged
loks0n merged 2 commits into1.8.xfrom
update-dotnet-sdk-0.21.2
Oct 13, 2025
Merged

Update .NET SDK to 0.21.2 and improve release detection#10641
loks0n merged 2 commits into1.8.xfrom
update-dotnet-sdk-0.21.2

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

@ChiragAgg5k ChiragAgg5k commented Oct 13, 2025

Summary

  • Update .NET SDK version to 0.21.2 with fix for Object[] array deserialization
  • Update sdk-generator dependency from 1.4.3 to 1.4.4
  • Improve SDK release detection logic to check actual commit SHA of latest release tag

Changes

SDK Version Update

  • Bumped .NET SDK version from 0.21.1 to 0.21.2 in app/config/platforms.php
  • Added changelog entry documenting the Object[] deserialization fix

SDK Generator Update

  • Updated sdk-generator dependency from 1.4.3 to 1.4.4 in composer.lock

Release Detection Improvement

  • Modified src/Appwrite/Platform/Tasks/SDKs.php to check the actual commit SHA of the latest release tag
  • Previously only checked if any release targeted the branch, which could miss cases where the latest commit already had a release
  • Now fetches the latest release tag's commit SHA and compares it with the latest commit on the branch
  • Prevents creating empty releases when the latest commit is already tagged

Test plan

  • Verify .NET SDK version is correctly updated
  • Verify SDK generator dependency is updated
  • Test release detection logic with existing releases

@ChiragAgg5k
Update .NET SDK to 0.21.2 and improve release detection
3b82141 
- Update .NET SDK version to 0.21.2 with Object[] deserialization fix
- Update sdk-generator dependency from 1.4.3 to 1.4.4
- Improve SDK release detection to check actual commit SHA of latest release tag instead of just checking releases targeting the branch
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 13, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

Updates the .NET SDK version in app/config/platforms.php from 0.21.1 to 0.21.2. Modifies src/Appwrite/Platform/Tasks/SDKs.php to change the release gating logic: instead of searching releases for a matching target commit, it now fetches the latest release tag, retrieves that tag's commit SHA, and compares it to the latest commit SHA; if they match, it skips creating a release. Other release flow, logging, and dry-run behavior remain unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • stnguyen90
  • abnegate

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely summarizes the two main changes in this pull request: the .NET SDK version bump to 0.21.2 and the improved release detection logic. It clearly reflects modifications in app/config/platforms.php and src/Appwrite/Platform/Tasks/SDKs.php without extraneous details. The phrasing is specific and readable, making the purpose of the PR clear at a glance.
Description Check ✅ Passed The pull request description thoroughly outlines all the relevant changes in both summary and detailed sections, covering the SDK version bump, the sdk-generator dependency update, and the release detection improvement. It also includes a clear test plan confirming verification of each change. The description is directly related to the actual modifications and provides meaningful context for reviewers.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-dotnet-sdk-0.21.2
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b82141 and 6f5ac23.

📒 Files selected for processing (1)
  • src/Appwrite/Platform/Tasks/SDKs.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Benchmark
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: CodeQL
  • GitHub Check: scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 13, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.44-r2 CVE-2025-5244 HIGH
binutils 2.44-r2 CVE-2025-5245 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

coderabbitai[bot]
coderabbitai bot reviewed Oct 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e303501 and 3b82141.

⛔ Files ignored due to path filters (2)
  • composer.lock is excluded by !**/*.lock
  • docs/sdks/dotnet/CHANGELOG.md is excluded by !docs/sdks/**
📒 Files selected for processing (2)
  • app/config/platforms.php (1 hunks)
  • src/Appwrite/Platform/Tasks/SDKs.php (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Linter
src/Appwrite/Platform/Tasks/SDKs.php

[error] 1-1: PSR-12: no_whitespace_in_blank_line. no whitespace is allowed on a blank line. Command: vendor/bin/pint --test --config pint.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Benchmark
  • GitHub Check: scan
🔇 Additional comments (1)
app/config/platforms.php (1)

358-361: .NET SDK version bump looks good.

The version aligns with the stated upgrade to 0.21.2 and matches the release objective.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 13, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,224
  • Requests with 200 status code: 220,293
  • P99 latency: 0.158222608

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,224 1,008
200 220,293 181,399
P99 0.158222608 0.191241951

@loks0n loks0n merged commit 3e47f94 into 1.8.x Oct 13, 2025
40 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0n loks0n loks0n approved these changes

+2 more reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@amustaque97 amustaque97 amustaque97 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChiragAgg5k @amustaque97 @loks0n