Skip to content

feat: add _APP_COMPUTE_BUILD_TIMEOUT to console variables#10674

Merged
Meldiron merged 5 commits into1.8.xfrom
feat-SER-457-add-max-build-duration-env
Oct 22, 2025
Merged

feat: add _APP_COMPUTE_BUILD_TIMEOUT to console variables#10674
Meldiron merged 5 commits into1.8.xfrom
feat-SER-457-add-max-build-duration-env

Conversation

@HarshMN2345
Copy link
Copy Markdown
Member

@HarshMN2345 HarshMN2345 commented Oct 21, 2025 •
edited
Loading

What does this PR do?

adding an env variable in the backend to expose max build duration for the frontend patch.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 21, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

Adds a new console environment variable _APP_COMPUTE_BUILD_TIMEOUT to the API response and documentation: the controller (app/controllers/api/console.php) now includes System::getEnv('_APP_COMPUTE_BUILD_TIMEOUT') in the variables Document returned by GET /v1/console/variables; the response model (src/Appwrite/Utopia/Response/Model/ConsoleVariables.php) defines _APP_COMPUTE_BUILD_TIMEOUT as an integer with example 900; and the e2e test (tests/e2e/Services/Console/ConsoleConsoleClientTest.php) is updated to expect one additional variable and assert its type. No other control-flow or behavior changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "feat: add _APP_COMPUTE_BUILD_TIMEOUT to console variables" accurately reflects the primary change in the changeset. The title is clear and specific, directly describing the addition of a new environment variable to the console variables response. The changeset confirms this is the main objective: the variable is added to the console controller response, defined in the ConsoleVariables model, and tested in the corresponding test file. The title is concise and provides sufficient context for a developer reviewing the repository history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The PR description states "adding an env variable in the backend to expose max build duration for the frontend patch," which directly aligns with the changeset. The modifications add the _APP_COMPUTE_BUILD_TIMEOUT environment variable to the console variables API response, include it in the ConsoleVariables model definition, and update the corresponding tests. The description accurately reflects the purpose and scope of these changes by specifying that an environment variable is being added to the backend to expose maximum build duration information. While the description is concise, it contains specific and meaningful information about what is being changed and why.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-SER-457-add-max-build-duration-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 21, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.44-r2 CVE-2025-5244 HIGH
binutils 2.44-r2 CVE-2025-5245 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
pcre2 10.43-r1 CVE-2025-58050 CRITICAL
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

coderabbitai[bot]
coderabbitai bot reviewed Oct 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/Appwrite/Utopia/Response/Model/ConsoleVariables.php (1)

25-30: Consider grouping with related compute variables.

The _APP_COMPUTE_BUILD_TIMEOUT variable is placed among domain-related variables (_APP_DOMAIN_TARGET_A, _APP_DOMAIN_TARGET_AAAA). For better organization and discoverability, consider placing it near the other compute-related variable _APP_COMPUTE_SIZE_LIMIT (around line 49-54).

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16a2dd0 and 803244c.

📒 Files selected for processing (3)
  • app/controllers/api/console.php (1 hunks)
  • src/Appwrite/Utopia/Response/Model/ConsoleVariables.php (1 hunks)
  • tests/e2e/Services/Console/ConsoleConsoleClientTest.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: CodeQL
  • GitHub Check: scan
🔇 Additional comments (2)
tests/e2e/Services/Console/ConsoleConsoleClientTest.php (2)

27-27: LGTM!

The count update correctly reflects the addition of the new _APP_COMPUTE_BUILD_TIMEOUT variable.

30-30: LGTM!

The type assertion correctly validates that _APP_COMPUTE_BUILD_TIMEOUT is an integer, matching the model definition.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 21, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,134
  • Requests with 200 status code: 204,245
  • P99 latency: 0.17062778

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,134 981
200 204,245 176,546
P99 0.17062778 0.198307353

HarshMN2345 and others added 2 commits October 21, 2025 17:47
@HarshMN2345 @coderabbitai
Update app/controllers/api/console.php
4cb20b3 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@HarshMN2345
Fix environment variable assignment for build timeout
d48ef37
@HarshMN2345 HarshMN2345 requested a review from abnegate October 22, 2025 04:54
@Meldiron Meldiron merged commit de03506 into 1.8.x Oct 22, 2025
40 checks passed
@HarshMN2345 HarshMN2345 deleted the feat-SER-457-add-max-build-duration-env branch October 22, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Meldiron Meldiron Meldiron approved these changes

@loks0n loks0n Awaiting requested review from loks0n

@vermakhushboo vermakhushboo Awaiting requested review from vermakhushboo

@abnegate abnegate Awaiting requested review from abnegate

+2 more reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@D0CT4 D0CT4 D0CT4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HarshMN2345 @Meldiron @D0CT4