Add test coverage for webp upload and preview functionality by Copilot · Pull Request #10739 · appwrite/appwrite

Copilot · 2025-10-30T21:51:51Z

Create webp test image (image.webp)
Move webp upload/view test into testCreateBucketFile
Rename testUploadWebpImage to testFilePreview and simplify to test preview with webp output
Add webp to allowed file extensions in testCreateBucketFile
Remove duplicate test functions and consolidate into existing tests
Fix test assertion - expect 1 file instead of 0 when using offset(1) since bucket now contains 2 files
Use simple webp image for testing (400x100px with pink/black colors)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

coderabbitai · 2025-10-30T21:52:15Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Note

Free review on us!

CodeRabbit is offering free reviews until Thu Nov 06 2025 to showcase some of the refinements we've made.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Co-authored-by: stnguyen90 <[email protected]>

stnguyen90 · 2025-10-30T22:06:55Z

tests/resources/logo.webp

@copilot this is an old logo. Use the new logo

Updated to use the new logo in commit d1511d5. Now using logo-after.webp instead of logo.webp.

tests/e2e/Services/Storage/StorageBase.php

stnguyen90 · 2025-10-30T22:18:14Z

tests/e2e/Services/Storage/StorageBase.php

+    /**
+     * @depends testCreateBucketFile
+     */
+    public function testUploadWebpImage(): array


@copilot Rename this to testFilePreview and move it right after testCreateBucketFile

Renamed to testFilePreview and simplified in commit d1511d5. The function now depends on testCreateBucketFile and tests previewing PNG as webp output format.

tests/e2e/Services/Storage/StorageBase.php

Co-authored-by: stnguyen90 <[email protected]>

tests/resources/image.webp

Copilot · 2025-11-02T02:44:39Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

appwrite.io
- Triggering command: curl -L -o /tmp/white.png REDACTED (dns block)
- Triggering command: wget -O /tmp/white.png REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

github-actions · 2025-11-02T03:15:06Z

Security Scan Results for PR

Docker Image Scan Results

Package	Version	Vulnerability	Severity
libxml2	2.13.8-r0	CVE-2025-49794	CRITICAL
libxml2	2.13.8-r0	CVE-2025-49796	CRITICAL
libxml2	2.13.8-r0	CVE-2025-49795	HIGH
libxml2	2.13.8-r0	CVE-2025-6021	HIGH
golang.org/x/crypto	v0.31.0	CVE-2025-22869	HIGH
golang.org/x/oauth2	v0.24.0	CVE-2025-22868	HIGH
stdlib	1.22.10	CVE-2025-47907	HIGH
stdlib	1.22.10	CVE-2025-47912	HIGH
stdlib	1.22.10	CVE-2025-58183	HIGH
stdlib	1.22.10	CVE-2025-58186	HIGH
stdlib	1.22.10	CVE-2025-58187	HIGH
stdlib	1.22.10	CVE-2025-58188	HIGH
stdlib	1.22.10	CVE-2025-61724	HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

github-actions · 2025-11-02T03:26:37Z

✨ Benchmark results

Requests per second: 1,174
Requests with 200 status code: 211,291
P99 latency: 0.165505982

⚡ Benchmark Comparison

Metric	This PR	Latest version
RPS	1,174	1,208
200	211,291	217,508
P99	0.165505982	0.169623058

stnguyen90

@copilot investigate why the tests are failing and fix them.

Co-authored-by: stnguyen90 <[email protected]>

Copilot · 2025-11-03T18:13:36Z

@copilot investigate why the tests are failing and fix them.

The tests were failing because adding the webp file upload to testCreateBucketFile increased the file count in the bucket from 1 to 2. The test at line 451 was asserting that offset(1) returns 0 files, but with 2 files in the bucket, it now returns 1 file.

Fixed in commit df8fb23 by updating the assertion to expect 1 file instead of 0.

tests/resources/image.webp

Copilot · 2025-11-03T19:56:03Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

github-production-user-asset-6210df.s3.amazonaws.com
- Triggering command: curl -L -o /tmp/new-logo.png REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

stnguyen90 · 2025-11-04T06:12:30Z

@copilot Since you cant download the right file, use any simple webp

Co-authored-by: stnguyen90 <[email protected]>

Copilot · 2025-11-04T06:16:56Z

@copilot Since you cant download the right file, use any simple webp

Created a simple 400x100px webp image with pink and black colors for testing in commit 2d33226.

tests/resources/image.webp

Co-authored-by: stnguyen90 <[email protected]>

stnguyen90 · 2025-11-05T23:41:09Z

Parent PR:

Fix webp upload and previews #10738

Initial plan

ce53997

Copilot AI assigned Copilot and stnguyen90 Oct 30, 2025

Copilot AI mentioned this pull request Oct 30, 2025

Fix webp upload and previews #10738

Merged

2 tasks

Copilot started work on behalf of stnguyen90 October 30, 2025 21:52 View session

Copilot AI and others added 2 commits October 30, 2025 21:56

Initial plan for adding webp test cases

de4f473

Co-authored-by: stnguyen90 <[email protected]>

Add webp test cases for upload/view and preview

4a8651a

Co-authored-by: stnguyen90 <[email protected]>

Copilot AI changed the title ~~[WIP] Fix webp upload and previews~~ Add test coverage for webp upload and preview functionality Oct 30, 2025

Copilot AI requested a review from stnguyen90 October 30, 2025 21:59

Copilot finished work on behalf of stnguyen90 October 30, 2025 21:59

stnguyen90 suggested changes Oct 30, 2025

View reviewed changes

Copilot started work on behalf of stnguyen90 October 30, 2025 22:21 View session

Refactor webp tests per review feedback

d1511d5

Co-authored-by: stnguyen90 <[email protected]>

Copilot AI requested a review from stnguyen90 October 30, 2025 22:27

Copilot finished work on behalf of stnguyen90 October 30, 2025 22:27

stnguyen90 suggested changes Nov 2, 2025

View reviewed changes

tests/resources/image.webp Show resolved Hide resolved

Copilot started work on behalf of stnguyen90 November 2, 2025 02:40 View session

Copilot AI requested a review from stnguyen90 November 2, 2025 02:44

Copilot finished work on behalf of stnguyen90 November 2, 2025 02:44

stnguyen90 suggested changes Nov 3, 2025

View reviewed changes

Copilot started work on behalf of stnguyen90 November 3, 2025 18:10 View session

Fix test assertion for file count with offset

df8fb23

Co-authored-by: stnguyen90 <[email protected]>

Copilot AI requested a review from stnguyen90 November 3, 2025 18:14

Copilot finished work on behalf of stnguyen90 November 3, 2025 18:14

stnguyen90 marked this pull request as ready for review November 3, 2025 18:14

stnguyen90 suggested changes Nov 3, 2025

View reviewed changes

tests/resources/image.webp Show resolved Hide resolved

Copilot started work on behalf of stnguyen90 November 3, 2025 19:54 View session

Copilot AI requested a review from stnguyen90 November 3, 2025 19:56

Copilot finished work on behalf of stnguyen90 November 3, 2025 19:56

Copilot started work on behalf of stnguyen90 November 4, 2025 06:14 View session

Replace with simple webp image for testing

2d33226

Co-authored-by: stnguyen90 <[email protected]>

Copilot finished work on behalf of stnguyen90 November 4, 2025 06:17

stnguyen90 suggested changes Nov 5, 2025

View reviewed changes

tests/resources/image.webp Show resolved Hide resolved

Copilot started work on behalf of stnguyen90 November 5, 2025 19:27 View session

Rename logo-after.webp to image.webp

8a9d0a3

Co-authored-by: stnguyen90 <[email protected]>

Copilot finished work on behalf of stnguyen90 November 5, 2025 19:31

Copilot AI requested a review from stnguyen90 November 5, 2025 19:31

stnguyen90 approved these changes Nov 5, 2025

View reviewed changes

stnguyen90 merged commit 4f1940a into fix-webp-library Nov 6, 2025
41 of 54 checks passed

stnguyen90 deleted the copilot/sub-pr-10738 branch November 6, 2025 23:07

Conversation

Copilot AI commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Free review on us!

Uh oh!

stnguyen90 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stnguyen90 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 2, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

github-actions bot commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Security Scan Results for PR

Docker Image Scan Results

Source Code Scan Results

Uh oh!

github-actions bot commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Benchmark results

⚡ Benchmark Comparison

Uh oh!

stnguyen90 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 3, 2025

Uh oh!

Uh oh!

Copilot AI commented Nov 3, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

stnguyen90 commented Nov 4, 2025

Uh oh!

Copilot AI commented Nov 4, 2025

Uh oh!

Uh oh!

stnguyen90 commented Nov 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Oct 30, 2025 •

edited

Loading

coderabbitai bot commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Nov 2, 2025 •

edited

Loading

github-actions bot commented Nov 2, 2025 •

edited

Loading