Skip to content

chore: release cli and php#10791

Merged
loks0n merged 6 commits into1.8.xfrom
release-cli-php
Nov 11, 2025
Merged

chore: release cli and php#10791
loks0n merged 6 commits into1.8.xfrom
release-cli-php

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 10, 2025

📝 Walkthrough

Walkthrough

This pull request updates SDK version identifiers in app/config/platforms.php: APP_PLATFORM_CONSOLE CLI SDK from 11.1.011.1.1, and APP_PLATFORM_SERVER PHP SDK from 17.5.018.0.1. It also modifies src/Appwrite/Platform/Tasks/SDKs.php: removed a global git config --global user.email command, added per-repository git configuration, replaced branch checkout logic with forced checkout/create fallback, added tolerant fetch/pull handling, hard resets of target branches with .github backup/restore, switched to additive staging (git add -A), and improved workspace cleanup and artifact copy/restore sequences. No public API signatures were changed.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

  • Changes include heterogeneous edits: a simple config bump plus substantial procedural changes to release/git workflows.
  • Areas to inspect closely:
    • app/config/platforms.php — verify only the intended version strings were updated and formatting remains valid.
    • src/Appwrite/Platform/Tasks/SDKs.php — review git workflow changes for correctness and edge cases (per-repo config, branch checkout/create logic, fetch/pull tolerances, hard reset behavior, .github backup/restore, staging/commit/push flow).
    • Confirm error handling and cleanup paths (conditional backup/restore) are correct and do not leave repositories in inconsistent states.
    • Validate that removing the global git config does not break environments that relied on it (CI agents, automated releases).

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining the purpose of the CLI and PHP SDK version updates and any relevant release notes or breaking changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: release cli and php' directly relates to the main changes in the pull request, which update CLI SDK version from 11.1.0 to 11.1.1 and PHP SDK version from 17.5.0 to 18.0.1.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release-cli-php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 10, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.44-r2 CVE-2025-5244 HIGH
binutils 2.44-r2 CVE-2025-5245 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
pcre2 10.43-r1 CVE-2025-58050 CRITICAL
github.com/containerd/containerd/v2 v2.0.2 CVE-2024-25621 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH
stdlib 1.22.10 CVE-2025-47912 HIGH
stdlib 1.22.10 CVE-2025-58183 HIGH
stdlib 1.22.10 CVE-2025-58186 HIGH
stdlib 1.22.10 CVE-2025-58187 HIGH
stdlib 1.22.10 CVE-2025-58188 HIGH
stdlib 1.22.10 CVE-2025-61724 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 10, 2025

✨ Benchmark results

  • Requests per second: 1,221
  • Requests with 200 status code: 219,789
  • P99 latency: 0.158688323

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,221 1,239
200 219,789 223,088
P99 0.158688323 0.164730252

Comment thread app/config/platforms.php Outdated
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4dc7009 and da73663.

⛔ Files ignored due to path filters (1)
  • docs/sdks/php/CHANGELOG.md is excluded by !docs/sdks/**
📒 Files selected for processing (2)
  • app/config/platforms.php (2 hunks)
  • src/Appwrite/Platform/Tasks/SDKs.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/config/platforms.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Benchmark
  • GitHub Check: scan

Comment thread src/Appwrite/Platform/Tasks/SDKs.php

$result = $health->getFailedJobs(
name: ::V1DATABASE(),
name: Name::V1DATABASE(),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rename this QueueName? Can we create a backlog task?

@loks0n loks0n merged commit 91c24b6 into 1.8.x Nov 11, 2025
90 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants