Fix operators in transactions by abnegate · Pull Request #10800 · appwrite/appwrite

abnegate · 2025-11-11T07:22:12Z

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

(Related PR or issue)

Checklist

Have you read the Contributing Guidelines on issues?
If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

# Conflicts: # composer.lock

coderabbitai · 2025-11-11T07:23:07Z

📝 Walkthrough

Walkthrough

The PR changes Databases HTTP action class inheritance and corresponding setHttpPath return types (several Action classes now extend DatabasesAction/AppwriteAction as appropriate). It adds a protected parseOperators(array $data, Document $collection): array helper to src/.../Databases/Action.php to convert operator representations into Operator objects with validation. Multiple document and bulk endpoints now skip operator parsing when transactionId is present and many transactional staging paths call $queueForEvents->reset() before returning staged responses. Transactions/Update.php caches collection objects per collection during commit and normalizes operation data. New end-to-end tests for array operators in transactions were added (duplicates present).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Inspect parseOperators implementation and error handling in:
- src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php
Verify inheritance and setHttpPath return-type changes in:
- src/.../Databases/Action.php
- src/.../Collections/Documents/Action.php
- src/.../Transactions/Action.php
Review transactional logic and event-queue resets across document endpoints:
- src/.../Transactions/Update.php (collection caching, data normalization)
- All modified Collections/Documents endpoints (Create, Update, Delete, Upsert, Bulk/*, Attribute Increment/Decrement)
Validate conditional operator parsing when transactionId is present and bulk operation semantics.
Run the new e2e transaction tests and remove duplicated test blocks if necessary.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 35.29% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.
Description check	❓ Inconclusive	The description is incomplete and contains only the repository's standard pull request template with empty placeholder sections, providing no meaningful information about the changeset.	Fill in the template sections with actual details about what the PR does, why it was needed, how it was tested, and any related issues or PRs.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fix operators in transactions' directly describes the main objective of the changeset, which focuses on fixing operator handling within database transactions across multiple files.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat-operators

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37f16ef and ab90563.

📒 Files selected for processing (1)

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: scan-pr / osv-scan
GitHub Check: Setup & Build Appwrite Image
GitHub Check: Setup & Build Appwrite Image
GitHub Check: scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-11-11T07:24:48Z

Security Scan Results for PR

Docker Image Scan Results

Package	Version	Vulnerability	Severity
libxml2	2.13.8-r0	CVE-2025-49794	CRITICAL
libxml2	2.13.8-r0	CVE-2025-49796	CRITICAL
libxml2	2.13.8-r0	CVE-2025-49795	HIGH
libxml2	2.13.8-r0	CVE-2025-6021	HIGH
github.com/containerd/containerd/v2	v2.0.2	CVE-2024-25621	HIGH
golang.org/x/crypto	v0.31.0	CVE-2025-22869	HIGH
golang.org/x/oauth2	v0.24.0	CVE-2025-22868	HIGH
stdlib	1.22.10	CVE-2025-47907	HIGH
stdlib	1.22.10	CVE-2025-58183	HIGH
stdlib	1.22.10	CVE-2025-58186	HIGH
stdlib	1.22.10	CVE-2025-58187	HIGH
stdlib	1.22.10	CVE-2025-58188	HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

github-actions · 2025-11-11T07:33:55Z

✨ Benchmark results

Requests per second: 1,200
Requests with 200 status code: 216,034
P99 latency: 0.163567512

⚡ Benchmark Comparison

Metric	This PR	Latest version
RPS	1,200	1,248
200	216,034	224,708
P99	0.163567512	0.16553235

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (4)

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php (4)

5641-5644: Avoid hand-written JSON for operators; build with json_encode (safer, clearer).

Hand-typed JSON strings are brittle and include an empty 'attribute'. Build via arrays to ensure valid JSON and omit unused keys.

@@
-            'data' => [
-                'items' => '{"method":"arrayRemove","attribute":"","values":["item2"]}'
-            ]
+            'data' => [
+                'items' => json_encode(['method' => 'arrayRemove', 'values' => ['item2']])
+            ]
@@
-            'data' => [
-                'items' => '{"method":"arrayInsert","attribute":"","values":[2,"newItem"]}'
-            ]
+            'data' => [
+                'items' => json_encode(['method' => 'arrayInsert', 'values' => [2, 'newItem']])
+            ]

See next comment for confirming TablesDB expects 'column' vs inferring from context.

Also applies to: 5655-5657

5765-5767: Same refactor for bulk createOperations operator payloads.

@@
-                    'data' => [
-                        'tags' => '{"method":"arrayRemove","attribute":"","values":["javascript"]}'
-                    ]
+                    'data' => [
+                        'tags' => json_encode(['method' => 'arrayRemove', 'values' => ['javascript']])
+                    ]
@@
-                    'data' => [
-                        'tags' => '{"method":"arrayAppend","attribute":"","values":["go","rust"]}'
-                    ]
+                    'data' => [
+                        'tags' => json_encode(['method' => 'arrayAppend', 'values' => ['go', 'rust']])
+                    ]

Also applies to: 5775-5776

5891-5895: Same refactor for multiple-operators test; also removes empty 'attribute'.

@@
-            'data' => [
-                'list1' => '{"method":"arrayPrepend","attribute":"","values":["z"]}'
-            ]
+            'data' => [
+                'list1' => json_encode(['method' => 'arrayPrepend', 'values' => ['z']])
+            ]
@@
-            'data' => [
-                'list2' => '{"method":"arrayAppend","attribute":"","values":["w"]}'
-            ]
+            'data' => [
+                'list2' => json_encode(['method' => 'arrayAppend', 'values' => ['w']])
+            ]
@@
-            'data' => [
-                'list3' => '{"method":"arrayRemove","attribute":"","values":["3"]}'
-            ]
+            'data' => [
+                'list3' => json_encode(['method' => 'arrayRemove', 'values' => ['3']])
+            ]

Also applies to: 5902-5905, 5913-5916

5610-5612: Optional: Replace fixed sleeps with a short poll to reduce flakiness/time.

Use a small polling helper to wait for column readiness (timeout/backoff) instead of sleep(2/3).

I can draft a polling helper if desired.

Also applies to: 5729-5731, 5860-5861

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9db6f9c and 1efe9fa.

⛔ Files ignored due to path filters (1)

composer.lock is excluded by !**/*.lock

📒 Files selected for processing (5)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php (2 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Action.php (2 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Transactions/Action.php (1 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Transactions/Update.php (2 hunks)
tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📚 Learning: 2025-10-02T10:16:48.075Z

Learnt from: abnegate
Repo: appwrite/appwrite PR: 10023
File: src/Appwrite/Databases/TransactionState.php:174-219
Timestamp: 2025-10-02T10:16:48.075Z
Learning: In `src/Appwrite/Databases/TransactionState.php`, the `listDocuments` method intentionally applies queries only to the initial database fetch of committed documents. Transaction state changes (creates, updates, deletes) are then overlaid on top of the filtered committed set without re-evaluating the queries against the final merged result. This is the intended behavior for transaction-aware document listing.

Applied to files:

src/Appwrite/Platform/Modules/Databases/Http/Databases/Transactions/Update.php

📚 Learning: 2025-06-19T09:20:03.312Z

Learnt from: ItzNotABug
Repo: appwrite/appwrite PR: 9693
File: src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php:57-59
Timestamp: 2025-06-19T09:20:03.312Z
Learning: In table-related endpoints (such as `src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php`), parameter descriptions should use "table" and "row" terminology instead of "collection" and "document" for clarity and consistency.

Applied to files:

src/Appwrite/Platform/Modules/Databases/Http/Databases/Transactions/Update.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Action.php

📚 Learning: 2025-05-10T04:12:13.037Z

Learnt from: ItzNotABug
Repo: appwrite/appwrite PR: 9693
File: src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Indexes/Delete.php:85-86
Timestamp: 2025-05-10T04:12:13.037Z
Learning: The class `Appwrite\Platform\Modules\Databases\Http\Databases\Collections\Indexes\Action` defines a method `getGrantParentNotFoundException()` which is used to handle cases where a parent resource (like a database collection) is not found.

Applied to files:

src/Appwrite/Platform/Modules/Databases/Http/Databases/Transactions/Action.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Action.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php

🧬 Code graph analysis (5)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Transactions/Update.php (1)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php (1)

parseOperators (36-87)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Transactions/Action.php (2)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php (2)

Action (11-88)

setHttpPath (20-26)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Action.php (2)

Action (12-395)

setHttpPath (24-44)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Action.php (2)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php (2)

Action (11-88)

setHttpPath (20-26)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Transactions/Action.php (2)

Action (7-66)

setHttpPath (14-20)

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php (2)

tests/e2e/Client.php (1)

Client (8-342)

tests/e2e/Scopes/Scope.php (1)

getHeaders (145-145)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php (2)

src/Appwrite/Extend/Exception.php (1)

Exception (7-464)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Action.php (2)

Action (12-395)

setHttpPath (24-44)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Setup & Build Appwrite Image
GitHub Check: Setup & Build Appwrite Image
GitHub Check: scan

🔇 Additional comments (1)

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php (1)

5636-5645: ****

The code correctly follows the Appwrite TablesDB pattern. For array operators in transactions, the operator object does not need a separate "column" key—the target column is inferred from the field key in the row payload. The payload structure with 'items' => '{"method":"arrayRemove",...}' is correct: items specifies the target column, and the operator operates on it. The empty 'attribute' field is part of the expected operator schema for array operators. No changes needed.

Likely an incorrect or invalid review comment.

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab5aac0 and c958297.

📒 Files selected for processing (9)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Decrement.php (1 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Increment.php (1 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Delete.php (1 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Update.php (2 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Upsert.php (2 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Create.php (1 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Delete.php (1 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Update.php (2 hunks)
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Upsert.php (2 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: abnegate
Repo: appwrite/appwrite PR: 10023
File: src/Appwrite/Databases/TransactionState.php:174-219
Timestamp: 2025-10-02T10:16:48.075Z
Learning: In `src/Appwrite/Databases/TransactionState.php`, the `listDocuments` method intentionally applies queries only to the initial database fetch of committed documents. Transaction state changes (creates, updates, deletes) are then overlaid on top of the filtered committed set without re-evaluating the queries against the final merged result. This is the intended behavior for transaction-aware document listing.

Learnt from: ItzNotABug
Repo: appwrite/appwrite PR: 9693
File: src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php:57-59
Timestamp: 2025-06-19T09:20:03.312Z
Learning: In table-related endpoints (such as `src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php`), parameter descriptions should use "table" and "row" terminology instead of "collection" and "document" for clarity and consistency.

📚 Learning: 2025-10-02T10:16:48.075Z

Learnt from: abnegate
Repo: appwrite/appwrite PR: 10023
File: src/Appwrite/Databases/TransactionState.php:174-219
Timestamp: 2025-10-02T10:16:48.075Z
Learning: In `src/Appwrite/Databases/TransactionState.php`, the `listDocuments` method intentionally applies queries only to the initial database fetch of committed documents. Transaction state changes (creates, updates, deletes) are then overlaid on top of the filtered committed set without re-evaluating the queries against the final merged result. This is the intended behavior for transaction-aware document listing.

Applied to files:

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Decrement.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Upsert.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Upsert.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Update.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Create.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Delete.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Increment.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Delete.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Update.php

📚 Learning: 2025-06-19T09:20:03.312Z

Learnt from: ItzNotABug
Repo: appwrite/appwrite PR: 9693
File: src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php:57-59
Timestamp: 2025-06-19T09:20:03.312Z
Learning: In table-related endpoints (such as `src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php`), parameter descriptions should use "table" and "row" terminology instead of "collection" and "document" for clarity and consistency.

Applied to files:

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Upsert.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Upsert.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Update.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Delete.php
src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Update.php

🧬 Code graph analysis (4)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Upsert.php (1)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php (1)

parseOperators (36-96)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Upsert.php (1)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php (1)

parseOperators (36-96)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Update.php (1)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php (1)

parseOperators (36-96)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Update.php (1)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php (1)

parseOperators (36-96)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: scan

🔇 Additional comments (12)

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Upsert.php (2)

121-123: LGTM: Conditional operator parsing is correct.

Skipping operator parsing when a transaction is present ensures that operators are evaluated at commit time rather than at staging time, which is the correct behavior for transactional consistency.

307-307: LGTM: Event queue reset for staged operations.

Resetting the event queue after staging prevents premature event emission for transactional operations. Events will be emitted when the transaction is committed.

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Increment.php (1)

155-156: LGTM: Event queue reset for staged increment operation.

Correctly resets the event queue after staging to prevent premature event emission.

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Upsert.php (2)

110-112: LGTM: Conditional operator parsing per document.

Correctly applies conditional operator parsing to each document in the bulk operation, maintaining consistency with single-document upsert behavior.

154-155: LGTM: Event queue reset for bulk staged operation.

Prevents bulk events from being emitted for staged operations.

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Decrement.php (1)

155-156: LGTM: Event queue reset for staged decrement operation.

Correctly resets the event queue after staging to prevent premature event emission, consistent with increment operations.

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Create.php (1)

415-416: LGTM: Event queue reset for staged create operations.

Correctly resets the event queue after staging for both single and bulk create operations, preventing premature event emission.

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Update.php (2)

110-112: LGTM: Conditional operator parsing for bulk updates.

Correctly defers operator parsing when operating within a transaction, ensuring operators are evaluated at commit time with the final document state.

179-180: LGTM: Event queue reset for bulk staged updates.

Prevents bulk update events from being emitted for staged operations.

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Delete.php (1)

179-180: LGTM: Event queue reset for staged delete operation.

Correctly resets the event queue after staging to prevent premature delete event emission.

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Update.php (2)

115-117: LGTM: Conditional operator parsing for updates.

Correctly skips operator parsing when operating within a transaction, deferring evaluation until commit time.

306-308: LGTM: Event queue reset for staged update operation.

Correctly resets the event queue after staging to prevent premature event emission for the update operation.

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Delete.php

# Conflicts: # composer.lock

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c958297 and 46d785b.

⛔ Files ignored due to path filters (1)

composer.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: abnegate
Repo: appwrite/appwrite PR: 10023
File: src/Appwrite/Databases/TransactionState.php:174-219
Timestamp: 2025-10-02T10:16:48.075Z
Learning: In `src/Appwrite/Databases/TransactionState.php`, the `listDocuments` method intentionally applies queries only to the initial database fetch of committed documents. Transaction state changes (creates, updates, deletes) are then overlaid on top of the filtered committed set without re-evaluating the queries against the final merged result. This is the intended behavior for transaction-aware document listing.

Learnt from: ItzNotABug
Repo: appwrite/appwrite PR: 9693
File: src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php:57-59
Timestamp: 2025-06-19T09:20:03.312Z
Learning: In table-related endpoints (such as `src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php`), parameter descriptions should use "table" and "row" terminology instead of "collection" and "document" for clarity and consistency.

📚 Learning: 2025-06-19T09:20:03.312Z

Learnt from: ItzNotABug
Repo: appwrite/appwrite PR: 9693
File: src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php:57-59
Timestamp: 2025-06-19T09:20:03.312Z
Learning: In table-related endpoints (such as `src/Appwrite/Platform/Modules/Databases/Http/Databases/Tables/Update.php`), parameter descriptions should use "table" and "row" terminology instead of "collection" and "document" for clarity and consistency.

Applied to files:

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php

🧬 Code graph analysis (1)

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php (2)

tests/e2e/Client.php (1)

Client (8-342)

tests/e2e/Scopes/Scope.php (1)

getHeaders (145-145)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Setup & Build Appwrite Image
GitHub Check: Setup & Build Appwrite Image
GitHub Check: scan

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php

…at-operators

abnegate added 2 commits November 11, 2025 20:20

Fix transactions + operators

74ff9a9

Merge remote-tracking branch 'origin/1.8.x' into feat-operators

1efe9fa

# Conflicts: # composer.lock

coderabbitai bot reviewed Nov 11, 2025

View reviewed changes

src/Appwrite/Platform/Modules/Databases/Http/Databases/Action.php Show resolved Hide resolved

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php Show resolved Hide resolved

abnegate added 5 commits November 11, 2025 21:09

Handle deep nested ops

94614d3

Fix keys

353e84b

Format

ab5aac0

Fix event firing on txn ops

ae21fad

Fix operator parsing on txn ops

c958297

coderabbitai bot reviewed Nov 12, 2025

View reviewed changes

src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Documents/Bulk/Delete.php Show resolved Hide resolved

abnegate added 2 commits November 12, 2025 17:02

Merge remote-tracking branch 'origin/1.8.x' into feat-operators

e564793

# Conflicts: # composer.lock

Fix tests

46d785b

coderabbitai bot reviewed Nov 12, 2025

View reviewed changes

tests/e2e/Services/Databases/TablesDB/Transactions/TransactionsBase.php Outdated Show resolved Hide resolved

abnegate added 5 commits November 12, 2025 21:54

Fix array conversion

37f16ef

Merge branch '1.8.x' into feat-operators

298e6f9

Use helper for tests

2ab36f4

Merge branch 'feat-operators' of github.com:appwrite/appwrite into fe…

082afce

…at-operators

Fix tests

ab90563

abnegate merged commit d0057ec into 1.8.x Nov 14, 2025
39 of 40 checks passed

abnegate deleted the feat-operators branch November 14, 2025 05:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix operators in transactions#10800

Fix operators in transactions#10800
abnegate merged 14 commits into1.8.xfrom
feat-operators

abnegate commented Nov 11, 2025

Uh oh!

coderabbitai bot commented Nov 11, 2025 •

edited

Loading

Walkthrough

Estimated code review effort

Uh oh!

github-actions bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

abnegate commented Nov 11, 2025

What does this PR do?

Test Plan

Related PRs and Issues

Checklist

Uh oh!

coderabbitai bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

github-actions bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Security Scan Results for PR

Docker Image Scan Results

Source Code Scan Results

Uh oh!

github-actions bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Benchmark results

⚡ Benchmark Comparison

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai bot commented Nov 11, 2025 •

edited

Loading

github-actions bot commented Nov 11, 2025 •

edited

Loading

github-actions bot commented Nov 11, 2025 •

edited

Loading