Update Flutter framework default build runtime version to 3.35#10807
Update Flutter framework default build runtime version to 3.35#10807lohanidamodar merged 2 commits into1.8.xfrom
Conversation
|
Warning Rate limit exceeded@lohanidamodar has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 52 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Flutter framework configuration in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/config/frameworks.php(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Linter
- GitHub Check: Setup & Build Appwrite Image
| 'name' => 'Flutter', | ||
| 'screenshotSleep' => 5000, | ||
| 'buildRuntime' => 'flutter-3.29', | ||
| 'buildRuntime' => 'flutter-3.35', |
There was a problem hiding this comment.
🧩 Analysis chain
Verify that Flutter 3.35 exists and the runtime is available.
The version bump from 3.29 to 3.35 looks correct syntactically. However, please confirm that Flutter 3.35 is a valid release and that the flutter-3.35 runtime is defined in the template-runtimes configuration.
First, verify that Flutter 3.35 is a valid release:
Then, run the following script to verify the runtime availability and check for any other references to the old version:
🏁 Script executed:
#!/bin/bash
echo "=== Checking template-runtimes configuration ==="
# Look for Flutter runtime definitions in config files
fd -e php -e json -e yaml --exec rg -nP 'flutter.*3\.(29|35)' {}
echo -e "\n=== Searching for any remaining references to flutter-3.29 ==="
rg -n 'flutter-3\.29'
echo -e "\n=== Checking FLUTTER versions in template-runtimes ==="
# Try to find where template-runtimes is defined
fd -e php -e json -e yaml --name '*runtime*' --exec cat {}Length of output: 744
🌐 Web query:
Flutter version 3.35 release
💡 Result:
Flutter 3.35 was released on August 13, 2025. Key highlights:
- Stateful hot reload on the web enabled by default (no experimental flag). [1]
- Experimental Widget Previews for isolated widget testing. [1][2]
- New DevTools feature: Flutter Property Editor and updated IDE instructions. [1]
- Accessibility improvements (SemanticRoles, better web semantics) and several Material/Cupertino updates. [1][2]
- Breaking changes/migrations included — see the breaking-changes page before upgrading. [1]
Sources: Flutter docs (What's New, release notes) and the Flutter 3.35 technical blog/announcement. [1][2]
References:
[1] Flutter — What’s new / release notes (Flutter docs), 13 Aug 2025.
[2] “What’s New in Flutter 3.35” announcement/technical blog.
Update Flutter version references consistently across all configuration files.
Flutter 3.35 was released on August 13, 2025 and is a valid release. However, the version bump is incomplete: while app/config/frameworks.php:276 is updated to flutter-3.35, two other files still reference flutter-3.29:
app/config/variables.php:1112— default template runtimesapp/config/templates/site.php:87— buildRuntime
Update both files to flutter-3.35 for consistency. Additionally, breaking changes/migrations are included — review the breaking-changes page before upgrading.
🤖 Prompt for AI Agents
In app/config/variables.php around line 1112 and app/config/templates/site.php
around line 87, update any occurrences of 'flutter-3.29' to 'flutter-3.35' so
the runtime version matches app/config/frameworks.php:276; ensure you change the
default template runtimes and buildRuntime entries respectively and run a quick
search across the repo to catch any other flutter-3.29 references, then verify
configuration syntax and consult the breaking-changes/migrations page before
deploying.
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
vermakhushboo
left a comment
There was a problem hiding this comment.
Do we need in more places like variables.php?
✨ Benchmark results
⚡ Benchmark Comparison
|
@vermakhushboo the |
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist