Skip to content

Update Flutter framework default build runtime version to 3.35#10807

Merged
lohanidamodar merged 2 commits into1.8.xfrom
feat-update-flutter-default-build-runtime
Nov 12, 2025
Merged

Update Flutter framework default build runtime version to 3.35#10807
lohanidamodar merged 2 commits into1.8.xfrom
feat-update-flutter-default-build-runtime

Conversation

@lohanidamodar
Copy link
Copy Markdown
Member

What does this PR do?

  • Update Flutter framework default build runtime version to 3.35

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 12, 2025

Warning

Rate limit exceeded

@lohanidamodar has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 79d7334 and d90b4c2.

📒 Files selected for processing (1)
  • app/config/templates/site.php (1 hunks)
📝 Walkthrough

Walkthrough

The Flutter framework configuration in app/config/frameworks.php has been updated with a buildRuntime version bump from flutter-3.29 to flutter-3.35. This is a straightforward version reference update with no changes to configuration structure or logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file modification with a direct version number update
  • No logic changes or structural modifications
  • Straightforward value replacement requiring minimal verification
  • Consider verifying the new version number (flutter-3.35) is a valid and intended update

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the Flutter framework default build runtime version to 3.35, which matches the changeset exactly.
Description check ✅ Passed The description is directly related to the changeset, clearly stating the purpose of updating the Flutter framework default build runtime version to 3.35.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d862245 and 79d7334.

📒 Files selected for processing (1)
  • app/config/frameworks.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Linter
  • GitHub Check: Setup & Build Appwrite Image

'name' => 'Flutter',
'screenshotSleep' => 5000,
'buildRuntime' => 'flutter-3.29',
'buildRuntime' => 'flutter-3.35',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify that Flutter 3.35 exists and the runtime is available.

The version bump from 3.29 to 3.35 looks correct syntactically. However, please confirm that Flutter 3.35 is a valid release and that the flutter-3.35 runtime is defined in the template-runtimes configuration.

First, verify that Flutter 3.35 is a valid release:

Then, run the following script to verify the runtime availability and check for any other references to the old version:


🏁 Script executed:

#!/bin/bash

echo "=== Checking template-runtimes configuration ==="
# Look for Flutter runtime definitions in config files
fd -e php -e json -e yaml --exec rg -nP 'flutter.*3\.(29|35)' {}

echo -e "\n=== Searching for any remaining references to flutter-3.29 ==="
rg -n 'flutter-3\.29'

echo -e "\n=== Checking FLUTTER versions in template-runtimes ==="
# Try to find where template-runtimes is defined
fd -e php -e json -e yaml --name '*runtime*' --exec cat {}

Length of output: 744


🌐 Web query:

Flutter version 3.35 release

💡 Result:

Flutter 3.35 was released on August 13, 2025. Key highlights:

  • Stateful hot reload on the web enabled by default (no experimental flag). [1]
  • Experimental Widget Previews for isolated widget testing. [1][2]
  • New DevTools feature: Flutter Property Editor and updated IDE instructions. [1]
  • Accessibility improvements (SemanticRoles, better web semantics) and several Material/Cupertino updates. [1][2]
  • Breaking changes/migrations included — see the breaking-changes page before upgrading. [1]

Sources: Flutter docs (What's New, release notes) and the Flutter 3.35 technical blog/announcement. [1][2]

References:
[1] Flutter — What’s new / release notes (Flutter docs), 13 Aug 2025.
[2] “What’s New in Flutter 3.35” announcement/technical blog.


Update Flutter version references consistently across all configuration files.

Flutter 3.35 was released on August 13, 2025 and is a valid release. However, the version bump is incomplete: while app/config/frameworks.php:276 is updated to flutter-3.35, two other files still reference flutter-3.29:

  • app/config/variables.php:1112 — default template runtimes
  • app/config/templates/site.php:87 — buildRuntime

Update both files to flutter-3.35 for consistency. Additionally, breaking changes/migrations are included — review the breaking-changes page before upgrading.

🤖 Prompt for AI Agents
In app/config/variables.php around line 1112 and app/config/templates/site.php
around line 87, update any occurrences of 'flutter-3.29' to 'flutter-3.35' so
the runtime version matches app/config/frameworks.php:276; ensure you change the
default template runtimes and buildRuntime entries respectively and run a quick
search across the repo to catch any other flutter-3.29 references, then verify
configuration syntax and consult the breaking-changes/migrations page before
deploying.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 12, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.44-r2 CVE-2025-5244 HIGH
binutils 2.44-r2 CVE-2025-5245 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
pcre2 10.43-r1 CVE-2025-58050 CRITICAL
github.com/containerd/containerd/v2 v2.0.2 CVE-2024-25621 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH
stdlib 1.22.10 CVE-2025-58183 HIGH
stdlib 1.22.10 CVE-2025-58186 HIGH
stdlib 1.22.10 CVE-2025-58187 HIGH
stdlib 1.22.10 CVE-2025-58188 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
Copy Markdown
Contributor

@vermakhushboo vermakhushboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need in more places like variables.php?

@github-actions
Copy link
Copy Markdown

✨ Benchmark results

  • Requests per second: 1,134
  • Requests with 200 status code: 204,210
  • P99 latency: 0.16856124

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,134 1,205
200 204,210 216,855
P99 0.16856124 0.169890187

@lohanidamodar
Copy link
Copy Markdown
Member Author

Do we need in more places like variables.php?

@vermakhushboo the _APP_SITES_RUNTIMES is no longer used, it's only referenced in variables.php, compose.phtml and docker-compose.yml and no-where else.

@lohanidamodar lohanidamodar merged commit a9c9f60 into 1.8.x Nov 12, 2025
41 of 42 checks passed
@lohanidamodar lohanidamodar deleted the feat-update-flutter-default-build-runtime branch November 12, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants