Skip to content

chore: change VCSDeploymentType enum to VCSReferenceType#10852

Merged
abnegate merged 1 commit into1.8.xfrom
vcs-reference-type
Nov 21, 2025
Merged

chore: change VCSDeploymentType enum to VCSReferenceType#10852
abnegate merged 1 commit into1.8.xfrom
vcs-reference-type

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 21, 2025

📝 Walkthrough

Walkthrough

The change updates enum type mappings in a specification format file. For two service paths ('functions' -> 'createVcsDeployment' and 'sites' -> 'createVcsDeployment'), the enum type parameter mapping was changed from VCSDeploymentType to VCSReferenceType. No modifications were made to logic, control flow, or public entity declarations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Homogeneous, repetitive changes applied consistently across two locations
  • Single file modification with no logic complexity
  • Straightforward enum type mapping updates

Specific areas for review:

  • Verify that VCSReferenceType is the correct enum type for both affected paths
  • Confirm no other related enum mappings in the same file require similar updates
  • Ensure the enum type change is semantically correct for the 'createVcsDeployment' operation

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive No description was provided by the author; the PR lacks any explanation of the rationale or context for the enum change. Consider adding a description explaining why this enum type change is necessary and what it affects in the codebase.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating an enum type from VCSDeploymentType to VCSReferenceType in the specification file.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vcs-reference-type

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fbdbb3 and ba10bed.

⛔ Files ignored due to path filters (8)
  • app/config/specs/open-api3-1.8.x-console.json is excluded by !app/config/specs/**
  • app/config/specs/open-api3-1.8.x-server.json is excluded by !app/config/specs/**
  • app/config/specs/open-api3-latest-console.json is excluded by !app/config/specs/**
  • app/config/specs/open-api3-latest-server.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-1.8.x-console.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-1.8.x-server.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-latest-console.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-latest-server.json is excluded by !app/config/specs/**
📒 Files selected for processing (1)
  • src/Appwrite/SDK/Specification/Format.php (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build SDK
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (2)
src/Appwrite/SDK/Specification/Format.php (2)

292-297: LGTM! Consistent with the functions service change.

The enum rename is applied consistently for the sites service as well, maintaining symmetry with the functions service change at line 266.


263-268: Enum rename from VCSDeploymentType to VCSReferenceType is correct and complete.

Verification confirms:

  • Both createVcsDeployment endpoints exist with valid WhiteList validators for the type parameter
  • Format.php correctly maps both services to VCSReferenceType (lines 266 and 295)
  • Old enum name VCSDeploymentType fully removed from codebase
  • Change follows established pattern (consistent with TemplateReferenceType)

This is a metadata rename for SDK generation only and does not affect the underlying API validators. The change is safe and complete.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Nov 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@10852

commit: ba10bed

@github-actions
Copy link
Copy Markdown

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
imagemagick 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-c++ 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-dev 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-heic 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-jpeg 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-jxl 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-libs 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-openexr 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-webp 7.1.2.3-r0 CVE-2025-62171 HIGH
libecpg 17.6-r0 CVE-2025-12818 HIGH
libecpg-dev 17.6-r0 CVE-2025-12818 HIGH
libpq 17.6-r0 CVE-2025-12818 HIGH
libpq-dev 17.6-r0 CVE-2025-12818 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
postgresql17-dev 17.6-r0 CVE-2025-12818 HIGH
github.com/containerd/containerd/v2 v2.0.2 CVE-2024-25621 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH
stdlib 1.22.10 CVE-2025-58183 HIGH
stdlib 1.22.10 CVE-2025-58186 HIGH
stdlib 1.22.10 CVE-2025-58187 HIGH
stdlib 1.22.10 CVE-2025-58188 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
Copy Markdown

✨ Benchmark results

  • Requests per second: 1,112
  • Requests with 200 status code: 200,199
  • P99 latency: 0.173831144

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,112 1,135
200 200,199 204,405
P99 0.173831144 0.181416987

@abnegate abnegate merged commit a4f7cf9 into 1.8.x Nov 21, 2025
44 checks passed
@ChiragAgg5k ChiragAgg5k deleted the vcs-reference-type branch November 21, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants