Skip to content

Update GeoDB database#10890

Merged
lohanidamodar merged 2 commits into1.8.xfrom
feat-update-geodb
Dec 2, 2025
Merged

Update GeoDB database#10890
lohanidamodar merged 2 commits into1.8.xfrom
feat-update-geodb

Conversation

@lohanidamodar
Copy link
Copy Markdown
Member

@lohanidamodar lohanidamodar commented Dec 2, 2025 •
edited
Loading

What does this PR do?

  • Update GeoDB Database
  • Update test IP for blocked region as new DB reports currently used test IP for a different country

Test Plan

  • Existing tests

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 2, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request updates the geodb service configuration in app/init/registers.php to reference a newer MaxMind DB file, changing dbip-country-lite-2024-09.mmdb to dbip-country-lite-2025-12.mmdb. Additionally, an end-to-end test fixture in tests/e2e/Services/Account/AccountBase.php changes the X-Forwarded-For header value in a failure-path test from 103.152.127.250 to 31.6.14.220. No other functional or control-flow changes or public API signature changes are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Confirm the new MMDB file (dbip-country-lite-2025-12.mmdb) exists at the expected location and follows project naming/path conventions.
  • Verify the MMDB file format/version is compatible with the geodb loader.
  • Review app/init/registers.php to ensure only the filename was changed and no additional logic was altered.
  • Check the E2E test update (tests/e2e/Services/Account/AccountBase.php) to confirm the IP change is intentional and that assertions remain valid.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update GeoDB database' directly reflects the main change: updating the GeoDB MMDB file from version 2024-09 to 2025-12.
Description check ✅ Passed The description clearly relates to the changeset, explaining the GeoDB database update and the associated test IP change due to the new database version.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-update-geodb
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98dbb03 and 866bd5e.

📒 Files selected for processing (1)
  • tests/e2e/Services/Account/AccountBase.php (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • tests/e2e/Services/Account/AccountBase.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: E2E Service Test (Teams)
  • GitHub Check: E2E Service Test (VCS)
  • GitHub Check: E2E Service Test (Sites)
  • GitHub Check: E2E Service Test (Proxy)
  • GitHub Check: E2E Service Test (Webhooks)
  • GitHub Check: E2E Service Test (Locale)
  • GitHub Check: E2E Service Test (Health)
  • GitHub Check: E2E Service Test (FunctionsSchedule)
  • GitHub Check: E2E Service Test (Databases/Legacy)
  • GitHub Check: E2E Service Test (Functions)
  • GitHub Check: E2E Service Test (Console)
  • GitHub Check: E2E Service Test (Databases/TablesDB)
  • GitHub Check: E2E Service Test (Account)
  • GitHub Check: E2E Service Test (Avatars)
  • GitHub Check: E2E Service Test (Site Screenshots)
  • GitHub Check: E2E General Test
  • GitHub Check: E2E Service Test (Dev Keys)
  • GitHub Check: Unit Test
  • GitHub Check: Benchmark
  • GitHub Check: scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
imagemagick 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-c++ 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-dev 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-heic 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-jpeg 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-jxl 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-libs 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-openexr 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-webp 7.1.2.3-r0 CVE-2025-62171 HIGH
libecpg 17.6-r0 CVE-2025-12818 HIGH
libecpg-dev 17.6-r0 CVE-2025-12818 HIGH
libpng 1.6.47-r0 CVE-2025-64720 HIGH
libpng 1.6.47-r0 CVE-2025-65018 HIGH
libpng-dev 1.6.47-r0 CVE-2025-64720 HIGH
libpng-dev 1.6.47-r0 CVE-2025-65018 HIGH
libpq 17.6-r0 CVE-2025-12818 HIGH
libpq-dev 17.6-r0 CVE-2025-12818 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
postgresql17-dev 17.6-r0 CVE-2025-12818 HIGH
github.com/containerd/containerd/v2 v2.0.2 CVE-2024-25621 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH
stdlib 1.22.10 CVE-2025-58183 HIGH
stdlib 1.22.10 CVE-2025-58186 HIGH
stdlib 1.22.10 CVE-2025-58187 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,196
  • Requests with 200 status code: 215,275
  • P99 latency: 0.16450378

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,196 1,276
200 215,275 229,768
P99 0.16450378 0.165893023

@lohanidamodar lohanidamodar merged commit 0386fde into 1.8.x Dec 2, 2025
42 checks passed
@lohanidamodar lohanidamodar deleted the feat-update-geodb branch December 2, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChiragAgg5k ChiragAgg5k ChiragAgg5k approved these changes

@abnegate abnegate Awaiting requested review from abnegate

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lohanidamodar @ChiragAgg5k