app/realtime.php (1)

82-99: Consider reordering the empty/console check before the cache lookup.

The cache lookup at line 88 calls $project->getSequence() before checking if the project is empty or console at line 97. Moving the short-circuit check earlier would avoid unnecessary cache operations for console/empty projects.

     $ctx = Coroutine::getContext();

-    if (!isset($ctx['getProjectDB'])) {
-        $ctx['getProjectDB'] = [];
-    }
-
-    if (isset($ctx['getProjectDB'][$project->getSequence()])) {
-        return $ctx['getProjectDB'][$project->getSequence()];
-    }
-
-    global $register;
-
-    /** @var Group $pools */
-    $pools = $register->get('pools');
-
     if ($project->isEmpty() || $project->getId() === 'console') {
         return getConsoleDB();
     }
+
+    if (!isset($ctx['getProjectDB'])) {
+        $ctx['getProjectDB'] = [];
+    }
+
+    if (isset($ctx['getProjectDB'][$project->getSequence()])) {
+        return $ctx['getProjectDB'][$project->getSequence()];
+    }
+
+    global $register;
+
+    /** @var Group $pools */
+    $pools = $register->get('pools');

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

app/realtime.php (1)

185-195: Key coroutine cache for getTimelimit by (key, limit, seconds) to avoid cross‑contamination.

getTimelimit() now accepts and uses $key, $limit, and $seconds when constructing TimeLimitRedis, which fixes the earlier “parameters ignored” bug. However, the coroutine cache always uses a single 'timelimit' entry, so the first call in a coroutine determines the configuration for all subsequent calls, even if different arguments are passed (e.g. if another caller or resource uses a different key/limit/window in the same coroutine).

To keep instances correctly scoped to their configuration while still caching per coroutine, cache by a composite context key derived from the arguments:

 function getTimelimit(string $key = "", int $limit = 0, int $seconds = 1): TimeLimitRedis
 {
     $ctx = Coroutine::getContext();
 
-    if (isset($ctx['timelimit'])) {
-        return $ctx['timelimit'];
-    }
-
-    return $ctx['timelimit'] = new TimeLimitRedis($key, $limit, $seconds, getRedis());
+    $cacheKey = "timelimit:{$key}:{$limit}:{$seconds}";
+
+    if (isset($ctx[$cacheKey])) {
+        return $ctx[$cacheKey];
+    }
+
+    return $ctx[$cacheKey] = new TimeLimitRedis($key, $limit, $seconds, getRedis());
 }

This preserves the new signature and avoids different abuse‑limit configurations unintentionally sharing a single TimeLimitRedis instance within a coroutine.

app/realtime.php (1)

198-208: Clarify unused $workerId in getTelemetry (and minor note on getRealtime).

getRealtime()’s coroutine‑context cache via $ctx['realtime'] is fine, and the global $realtime = getRealtime(); keeps the single instance used throughout this file.

In getTelemetry(int $workerId), the $workerId parameter is currently unused, which is what PHPMD flags. If that’s intentional (e.g. placeholder for a future adapter that differentiates by worker), it would help static analysis and reader clarity to either:

• Rename it to $_workerId to explicitly mark it unused, or
• Add a short docblock comment noting that it’s unused by the current NoTelemetry implementation but kept for API compatibility.

Example:

-function getTelemetry(int $workerId): Utopia\Telemetry\Adapter
+function getTelemetry(int $_workerId): Utopia\Telemetry\Adapter
 {
     $ctx = Coroutine::getContext();

Also applies to: 211-222

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro