Fix ScheduleExecutions: inverted comparison prevented execution scheduling#10916
Merged
stnguyen90 merged 3 commits into1.8.xfrom Dec 8, 2025
Merged
Fix ScheduleExecutions: inverted comparison prevented execution scheduling#10916stnguyen90 merged 3 commits into1.8.xfrom
stnguyen90 merged 3 commits into1.8.xfrom
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
…xecute scheduled tasks Co-authored-by: stnguyen90 <[email protected]>
Copilot
AI
changed the title
[WIP] Fix bug in scheduled executions not being executed
Fix ScheduleExecutions: inverted comparison prevented execution scheduling
Dec 7, 2025
This prevents the warning: Swoole\Coroutine::sleep(): Timer must be greater than or equal to 0.001
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
Contributor
|
Tested by:
Prior to this change, the executions were never triggered. After this change, all the old ones triggered. |
stnguyen90
approved these changes
Dec 8, 2025
loks0n
approved these changes
Dec 8, 2025
✨ Benchmark results
⚡ Benchmark Comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes inverted comparison logic in
ScheduleExecutions.phpthat prevented scheduled executions from running. The condition was skipping executions that should execute and processing ones scheduled too far in the future.Change:
The logic now matches the pattern in
ScheduleMessages.phpandScheduleFunctions.php, wherescheduledAt > thresholdcorrectly identifies items not yet ready for processing.Test Plan
ScheduleMessages.php:38andScheduleFunctions.php:64-66Related PRs and Issues
Checklist
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.