Skip to content

Tableid and Collectionid in increment and decrement routes #10952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 2 commits into from
Dec 16, 2025
Merged

Tableid and Collectionid in increment and decrement routes #10952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70395cf
added tableid and collectionid in increment and decrement
ArnabChatterjee20k Dec 13, 2025
e4e6c84
linting
ArnabChatterjee20k Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...e/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Decrement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ public function action(string $databaseId, string $collectionId, string $documen
value: $value,
min: $min
);
$document->setAttribute('$' . $this->getCollectionsEventsContext() . 'Id', $collectionId);
} catch (ConflictException) {
throw new Exception($this->getConflictException());
} catch (NotFoundException) {
Expand Down
1 change: 1 addition & 0 deletions ...e/Platform/Modules/Databases/Http/Databases/Collections/Documents/Attribute/Increment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ public function action(string $databaseId, string $collectionId, string $documen
value: $value,
max: $max
);
$document->setAttribute('$' . $this->getCollectionsEventsContext() . 'Id', $collectionId);
} catch (ConflictException) {
throw new Exception($this->getConflictException());
} catch (NotFoundException) {
Expand Down
2 changes: 2 additions & 0 deletions tests/e2e/Services/Databases/Legacy/DatabasesBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6118,6 +6118,7 @@ public function testIncrementAttribute(): void
]));
$this->assertEquals(200, $inc['headers']['status-code']);
$this->assertEquals(6, $inc['body']['count']);
$this->assertEquals($collectionId, $inc['body']['$collectionId']);

// Verify count = 6
$get = $this->client->call(Client::METHOD_GET, "/databases/$databaseId/collections/$collectionId/documents/$docId", array_merge([
Expand Down Expand Up @@ -6229,6 +6230,7 @@ public function testDecrementAttribute(): void
]));
$this->assertEquals(200, $dec['headers']['status-code']);
$this->assertEquals(9, $dec['body']['count']);
$this->assertEquals($collectionId, $dec['body']['$collectionId']);

$get = $this->client->call(Client::METHOD_GET, '/databases/' . $databaseId . '/collections/' . $collectionId . '/documents/' . $documentId, array_merge([
'content-type' => 'application/json',
Expand Down
2 changes: 2 additions & 0 deletions tests/e2e/Services/Databases/TablesDB/DatabasesBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7760,6 +7760,7 @@ public function testIncrementColumn(): void
'x-appwrite-project' => $this->getProject()['$id'],
]));
$this->assertEquals(200, $inc['headers']['status-code']);
$this->assertEquals($tableId, $inc['body']['$tableId']);
$this->assertEquals(6, $inc['body']['count']);

// Verify count = 6
Expand Down Expand Up @@ -7872,6 +7873,7 @@ public function testDecrementColumn(): void
]));
$this->assertEquals(200, $dec['headers']['status-code']);
$this->assertEquals(9, $dec['body']['count']);
$this->assertEquals($tableId, $dec['body']['$tableId']);

$get = $this->client->call(Client::METHOD_GET, '/tablesdb/' . $databaseId . '/tables/' . $tableId . '/rows/' . $rowId, array_merge([
'content-type' => 'application/json',
Expand Down