Skip to content

Scheduler base patch chunks#10969

Merged
loks0n merged 1 commit into1.8.xfrom
fix-scheduler-base
Dec 16, 2025
Merged

Scheduler base patch chunks#10969
loks0n merged 1 commit into1.8.xfrom
fix-scheduler-base

Conversation

@fogelito
Copy link
Copy Markdown
Contributor

@fogelito fogelito commented Dec 16, 2025

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 16, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The batch size parameter used when loading missing project documents in the collectSchedules method was reduced from 10,000 to 499. This change modifies how projects are fetched during schedule collection by creating smaller batches, thereby increasing the number of iterations required to process the same volume of data. No logic, control flow, or data structures were altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file affected with one parameter value change
  • No logic or structural modifications
  • Homogeneous change (single adjustment)
  • Key consideration: Verify the intent behind the batch size reduction from 10,000 to 499 and confirm it does not introduce unintended performance degradation or conflict with system constraints

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is completely empty of actual implementation details, test plan, or any substantive explanation of the changes, containing only the contribution template with unfilled placeholder sections. Provide a concrete description explaining why the batch size was reduced, the performance implications, how the change was tested, and any related issues or PRs.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'Scheduler base patch chunks' is vague and doesn't clearly convey what specific change was made, despite being tangentially related to the changeset involving batch size adjustment in the scheduler. Consider a more descriptive title such as 'Reduce scheduler batch size from 10000 to 499 for project loading' to clearly communicate the specific change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-scheduler-base

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 16, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

coderabbitai[bot]
coderabbitai bot reviewed Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a09913 and 8d4c6a8.

📒 Files selected for processing (1)
  • src/Appwrite/Platform/Tasks/ScheduleBase.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 16, 2025

✨ Benchmark results

  • Requests per second: 1,195
  • Requests with 200 status code: 215,140
  • P99 latency: 0.160440489

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,195 1,277
200 215,140 229,969
P99 0.160440489 0.157554126

@loks0n loks0n merged commit eabe06d into 1.8.x Dec 16, 2025
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0n loks0n loks0n approved these changes

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fogelito @loks0n