Skip to content

Use platform in migrations worker#10976

Merged
ItzNotABug merged 1 commit into1.8.xfrom
platforms-in-migrations
Dec 17, 2025
Merged

Use platform in migrations worker#10976
ItzNotABug merged 1 commit into1.8.xfrom
platforms-in-migrations

Conversation

@ItzNotABug
Copy link
Copy Markdown
Contributor

What does this PR do?

Migrations worker had wrong logic.

Test Plan

N/A.

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@ItzNotABug ItzNotABug self-assigned this Dec 17, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • main
  • 1.6.x
  • 1.7.x
  • 1.8.x

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch platforms-in-migrations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

loks0n
loks0n previously approved these changes Dec 17, 2025
@github-actions
Copy link
Copy Markdown

✨ Benchmark results

  • Requests per second: 1,052
  • Requests with 200 status code: 189,412
  • P99 latency: 0.181120544

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,052 1,084
200 189,412 195,121
P99 0.181120544 0.187314668

Base automatically changed from update-template to 1.8.x December 17, 2025 12:36
@ItzNotABug ItzNotABug dismissed loks0n’s stale review December 17, 2025 12:36

The base branch was changed.

@ItzNotABug ItzNotABug merged commit 8d94b65 into 1.8.x Dec 17, 2025
71 of 73 checks passed
@ItzNotABug ItzNotABug deleted the platforms-in-migrations branch December 17, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants