Skip to content

Chore specs#10983

Merged
abnegate merged 6 commits into1.8.xfrom
chore-specs
Dec 18, 2025
Merged

Chore specs#10983
abnegate merged 6 commits into1.8.xfrom
chore-specs

Conversation

@abnegate
Copy link
Copy Markdown
Member

@abnegate abnegate commented Dec 18, 2025

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 18, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request updates minor version numbers for nine server-side SDK entries in app/config/sdks.php (Node.js, PHP, Python, Ruby, Go, .NET, Dart, Kotlin, Swift). It also changes the Collections Create endpoint documentation/description for the attributes parameter to remove the "relationship" type from the list of allowed attribute types (now: string, integer, float, boolean, datetime).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • SDK version updates are homogeneous, pure version bumps across multiple entries.
  • Attributes parameter change is a single textual/validation guidance adjustment that may affect consumers.

Areas requiring attention:

  • Confirm the SDK version increments match upstream releases.
  • Verify removing "relationship" is intentional and check for required migration or deprecation notes.
  • Search for other occurrences of the "relationship" attribute type in docs/tests/validation to ensure consistency.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is an empty template with no actual content filled in; it contains only placeholder sections and does not describe any part of the changeset. Complete the PR description by explaining what changes were made (SDK version updates and documentation updates), why they were made, and how to verify them.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'Chore specs' is vague and generic, using non-descriptive terms that don't convey meaningful information about the specific changes (SDK version updates and documentation adjustment). Use a more specific title that describes the main changes, such as 'Update SDK versions and database collection attributes documentation' or 'Chore: update SDK versions and remove relationship type from collection attributes'.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-specs
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6781cb and 937cac4.

⛔ Files ignored due to path filters (8)
  • app/config/specs/open-api3-1.8.x-console.json is excluded by !app/config/specs/**
  • app/config/specs/open-api3-1.8.x-server.json is excluded by !app/config/specs/**
  • app/config/specs/open-api3-latest-console.json is excluded by !app/config/specs/**
  • app/config/specs/open-api3-latest-server.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-1.8.x-console.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-1.8.x-server.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-latest-console.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-latest-server.json is excluded by !app/config/specs/**
📒 Files selected for processing (1)
  • src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Create.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/Appwrite/Platform/Modules/Databases/Http/Databases/Collections/Create.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build SDK
  • GitHub Check: scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Dec 18, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@10983

commit: 937cac4

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 18, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 18, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,174
  • Requests with 200 status code: 211,453
  • P99 latency: 0.167809764

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,174 1,244
200 211,453 223,999
P99 0.167809764 0.163695448

@abnegate abnegate merged commit 9bda831 into 1.8.x Dec 18, 2025
42 checks passed
@abnegate abnegate deleted the chore-specs branch December 18, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChiragAgg5k ChiragAgg5k ChiragAgg5k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abnegate @ChiragAgg5k