Skip to content

Update: Header name.#10992

Merged
abnegate merged 2 commits into1.8.xfrom
update-header-name
Dec 19, 2025
Merged

Update: Header name.#10992
abnegate merged 2 commits into1.8.xfrom
update-header-name

Conversation

@ItzNotABug
Copy link
Copy Markdown
Contributor

@ItzNotABug ItzNotABug commented Dec 19, 2025

What does this PR do?

Update header name to platform instead of profile.

Test Plan

N/A.

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@ItzNotABug ItzNotABug self-assigned this Dec 19, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 19, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

Added the header X-Appwrite-Platform to the CORS allowed headers in app/init/resources.php. Updated the HTTP options test in tests/e2e/General/HTTPTest.php to expect the Access-Control-Allow-Headers response to include X-Appwrite-Platform (position in the header list adjusted accordingly). No other logic, signatures, or control flow changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Homogeneous change: same header added in config and test.
  • Files to check closely:
    • app/init/resources.php — ensure header addition is correctly placed and formatted.
    • tests/e2e/General/HTTPTest.php — confirm expected header string matches production ordering/format.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'Update: Header name.' is vague and generic, using non-descriptive terminology that doesn't convey the specific change (from 'profile' to 'platform' header name). Consider a more specific title like 'Update X-Appwrite-Platform header name' or 'Rename header from profile to platform' to clarify the actual change.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly states the change—updating header name from 'profile' to 'platform'—and relates directly to the changeset modifications.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-header-name
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f1eee3 and 33f90fc.

📒 Files selected for processing (2)
  • app/init/resources.php (1 hunks)
  • tests/e2e/General/HTTPTest.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • app/init/resources.php
  • tests/e2e/General/HTTPTest.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: E2E Service Test (Databases/Legacy)
  • GitHub Check: E2E Service Test (Proxy)
  • GitHub Check: E2E Service Test (Projects)
  • GitHub Check: E2E Service Test (GraphQL)
  • GitHub Check: E2E Service Test (Tokens)
  • GitHub Check: E2E Service Test (Console)
  • GitHub Check: E2E Service Test (Functions)
  • GitHub Check: Unit Test
  • GitHub Check: E2E Service Test (Site Screenshots)
  • GitHub Check: E2E Service Test (Dev Keys)
  • GitHub Check: E2E General Test
  • GitHub Check: scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 19, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

abnegate
abnegate reviewed Dec 19, 2025
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 19, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,107
  • Requests with 200 status code: 199,243
  • P99 latency: 0.175770078

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,107 1,120
200 199,243 201,648
P99 0.175770078 0.180636763

@abnegate abnegate merged commit a7b243a into 1.8.x Dec 19, 2025
99 of 103 checks passed
@ItzNotABug ItzNotABug deleted the update-header-name branch December 19, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegate abnegate abnegate approved these changes

Assignees

@ItzNotABug ItzNotABug

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ItzNotABug @abnegate