Skip to content

Revert "Fix auth calls"#10995

Merged
abnegate merged 1 commit into1.8.xfrom
revert-10987-fix-auth
Dec 19, 2025
Merged

Revert "Fix auth calls"#10995
abnegate merged 1 commit into1.8.xfrom
revert-10987-fix-auth

Conversation

@abnegate
Copy link
Copy Markdown
Member

Reverts #10987

@abnegate abnegate merged commit 71621f4 into 1.8.x Dec 19, 2025
8 of 10 checks passed
@abnegate abnegate deleted the revert-10987-fix-auth branch December 19, 2025 13:54
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 19, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request removes dependency injection of the Authorization class from multiple router callback functions in app/controllers/general.php. Three callback blocks have been updated: the main router callback, the automatic certificate generation App::init() block, and the main App::init() router group callback. Concurrent with removing the injected parameter, instance method calls to Authorization have been replaced with static method calls (disable() and reset()).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single file affected with consistent, repetitive refactoring pattern (dependency injection removal)
  • Three similar code blocks updated using the same pattern
  • No new business logic introduced; purely structural changes in dependency access pattern
  • Consider verifying that Authorization::disable() and Authorization::reset() static methods exist and function equivalently to their instance counterparts
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-10987-fix-auth

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a20392d and 68deee4.

📒 Files selected for processing (1)
  • app/controllers/general.php (3 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
Copy Markdown

✨ Benchmark results

  • Requests per second: 1,298
  • Requests with 200 status code: 233,727
  • P99 latency: 0.154701419

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,298 1,381
200 233,727 248,613
P99 0.154701419 0.151150582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant