Skip to content

chore: remove warning logs when skipping ssl certificate#11024

Merged
ChiragAgg5k merged 1 commit into1.8.xfrom
turnoff-warning-logs
Dec 27, 2025
Merged

chore: remove warning logs when skipping ssl certificate#11024
ChiragAgg5k merged 1 commit into1.8.xfrom
turnoff-warning-logs

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

@ChiragAgg5k ChiragAgg5k commented Dec 27, 2025

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 27, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request removes three console warning log messages from the SSL certificate generation logic in app/controllers/general.php. The warnings were emitted when: a domain is not publicly accessible, an ACME challenge is being processed, or a domain is not a main domain. The control flow logic remains unchanged, with return statements executing as before. Only the warning message emissions are eliminated, with no modifications to public APIs or exported entities.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch turnoff-warning-logs
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73d3d15 and 7e37046.

📒 Files selected for processing (1)
  • app/controllers/general.php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChiragAgg5k ChiragAgg5k changed the title Fix: robust SMTP validation and added regression test chore: remove warning logs when skipping ssl certificate Dec 27, 2025
@ChiragAgg5k ChiragAgg5k merged commit a37b4a4 into 1.8.x Dec 27, 2025
12 of 13 checks passed
@ChiragAgg5k ChiragAgg5k deleted the turnoff-warning-logs branch December 27, 2025 14:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 27, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 27, 2025

✨ Benchmark results

  • Requests per second: 1,165
  • Requests with 200 status code: 209,675
  • P99 latency: 0.165875598

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,165 1,237
200 209,675 222,774
P99 0.165875598 0.165410716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0n loks0n loks0n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChiragAgg5k @loks0n