Skip to content

feat: graceful workers#11104

Merged
loks0n merged 1 commit into1.8.xfrom
feat-graceful-workers
Jan 7, 2026
Merged

feat: graceful workers#11104
loks0n merged 1 commit into1.8.xfrom
feat-graceful-workers

Conversation

@loks0n
Copy link
Copy Markdown
Member

@loks0n loks0n commented Jan 7, 2026

No description provided.

@loks0n loks0n changed the base branch from main to 1.8.x January 7, 2026 16:39
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 7, 2026

📝 Walkthrough

Walkthrough

This PR updates the utopia-php/queue dependency from 0.11.* to 0.15.* in composer.json and removes the worker startup logging in app/worker.php. The worker initialization block containing the "Worker ... started" log message and the associated workerStart() action has been removed, with $worker->start() now being called directly without the initialization side-effects.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'feat: graceful workers' is vague and does not clearly convey the specific changes made to the codebase, which involve removing startup logging from worker initialization and upgrading a dependency. Consider using a more specific title that describes the actual changes, such as 'refactor: remove worker startup logging' or 'chore: upgrade utopia-php/queue dependency'.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether the intent and context of the changes are properly documented. Add a detailed pull request description explaining the purpose of removing worker startup logging, why the dependency upgrade is necessary, and any breaking changes or migration notes.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jan 7, 2026

Open in StackBlitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@11104

commit: e25d52f

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2026

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@loks0n loks0n force-pushed the feat-graceful-workers branch from e25d52f to eecfba2 Compare January 7, 2026 16:50
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @composer.json:
- Line 72: Update the composer.json dependency for utopia-php/queue to a valid
published version: replace the current constraint "utopia-php/queue": "0.15.*"
with an available release such as "utopia-php/queue": "0.13.*" (or the exact
"0.13.0"), then run composer validate/install to ensure the new constraint
resolves correctly.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ded06d7 and eecfba2.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • app/worker.php
  • composer.json
💤 Files with no reviewable changes (1)
  • app/worker.php
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-22T06:23:32.026Z
Learnt from: ItzNotABug
Repo: appwrite/appwrite PR: 10348
File: app/controllers/shared/api.php:546-546
Timestamp: 2025-08-22T06:23:32.026Z
Learning: In Appwrite's codebase, Utopia\Queue\Broker\Pool (aliased as BrokerPool) is a readonly class that implements both Publisher and Consumer interfaces, allowing it to be used directly in constructors expecting either interface type. This is extensively used throughout the codebase for queue operations.

Applied to files:

  • composer.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: E2E Service Test (Sites)
  • GitHub Check: E2E Service Test (Projects)
  • GitHub Check: E2E Service Test (Proxy)
  • GitHub Check: E2E Service Test (Tokens)
  • GitHub Check: E2E Service Test (Users)
  • GitHub Check: E2E Service Test (Console)
  • GitHub Check: E2E Service Test (GraphQL)
  • GitHub Check: E2E Service Test (FunctionsSchedule)
  • GitHub Check: E2E Service Test (Avatars)
  • GitHub Check: E2E Service Test (Health)
  • GitHub Check: E2E Service Test (Realtime)
  • GitHub Check: E2E Service Test (Functions)
  • GitHub Check: E2E Service Test (Databases/Legacy)
  • GitHub Check: E2E Service Test (Databases/TablesDB)
  • GitHub Check: E2E General Test
  • GitHub Check: E2E Service Test (Site Screenshots)
  • GitHub Check: Unit Test
  • GitHub Check: E2E Service Test (Abuse enabled)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2026

✨ Benchmark results

  • Requests per second: 2,228
  • Requests with 200 status code: 401,149
  • P99 latency: 0.079115143

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 2,228 1,252
200 401,149 225,465
P99 0.079115143 0.162751116

@loks0n loks0n merged commit f2ac01b into 1.8.x Jan 7, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant