Skip to content

Introspection flag#11159

Merged
abnegate merged 1 commit into1.8.xfrom
feat-graphql-introspection
Jan 19, 2026
Merged

Introspection flag#11159
abnegate merged 1 commit into1.8.xfrom
feat-graphql-introspection

Conversation

@abnegate
Copy link
Copy Markdown
Member

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

This pull request adds a new configurable GraphQL introspection feature to the application. A new environment variable _APP_GRAPHQL_INTROSPECTION is introduced and propagated through the configuration layers: defined in .env with a default value of "enabled", declared in app/config/variables.php as a configuration entry, and exposed in Docker Compose files. The GraphQL controller is updated with conditional logic to disable introspection validation rules when the variable is set to "disabled".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is a template with empty sections and does not provide actual implementation details, motivation, test plan, or related issues for the changeset. Fill in the template sections with concrete details about what the PR does, why it's needed, how changes were tested, and any related issues or PRs.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Introspection flag' directly relates to the main change: adding a new _APP_GRAPHQL_INTROSPECTION configuration flag to enable/disable GraphQL introspection across multiple configuration files and controllers.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In @.env:
- Line 131: Move the environment key _APP_TRUSTED_HEADERS so it appears before
_APP_USAGE_AGGREGATION_INTERVAL in the .env file to satisfy dotenv-linter
ordering; locate the line containing _APP_TRUSTED_HEADERS and cut/paste it
directly above the line containing _APP_USAGE_AGGREGATION_INTERVAL, preserving
the exact key/value string.
- Line 109: Move the environment variable declaration
_APP_GRAPHQL_INTROSPECTION=enabled so it appears before
_APP_INTERVAL_CLEANUP_STALE_EXECUTIONS in the .env content to satisfy
dotenv-linter ordering; locate the two keys (_APP_GRAPHQL_INTROSPECTION and
_APP_INTERVAL_CLEANUP_STALE_EXECUTIONS) and swap or reposition the
_APP_GRAPHQL_INTROSPECTION entry to come immediately before the
_APP_INTERVAL_CLEANUP_STALE_EXECUTIONS entry.

@github-actions
Copy link
Copy Markdown

✨ Benchmark results

  • Requests per second: 2,204
  • Requests with 200 status code: 396,772
  • P99 latency: 0.079686576

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 2,204 1,243
200 396,772 223,744
P99 0.079686576 0.163584644

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 19, 2026

@abnegate I've opened a new pull request, #11160, to work on those changes. Once the pull request is ready, I'll request review from you.

@abnegate abnegate merged commit a7898b3 into 1.8.x Jan 19, 2026
47 checks passed
@abnegate abnegate deleted the feat-graphql-introspection branch January 19, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants