Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/controllers/general.php`:
- Around line 1076-1088: The cache key is inconsistent: exists() checks
md5($hostname) while set() uses md5($domain->get()), so normalize and reuse the
same key; call $hostnameRaw = $request->getHostname(), create Domain $domain =
new Domain($hostnameRaw ?: ''), compute $cacheKey = md5($domain->get()) (or md5
of the normalized string you choose) and replace both
$hostnames->exists(md5($hostname)) and $hostnames->set(md5($domain->get()), ...)
with $hostnames->exists($cacheKey) and $hostnames->set($cacheKey, ...) so the
lookup and write use the exact same key (refer to Request::getHostname,
Domain::get/isKnown/isTest, and $hostnames->exists/$hostnames->set).

In `@app/http.php`:
- Around line 47-49: The Swoole Table ($hostnames) is created with only 100_000
rows and currently has no eviction, so calls to $hostnames->set(...) can
silently return false when the table is full; update the code paths that write
to $hostnames (calls to $hostnames->set) to check the boolean return and log an
error including the key and context when set() returns false, and either
increase the initial Table size (match the $domains table’s 1_000_000 rows or
make size configurable) or add a TTL/eviction scheme by adding a timestamp
column (e.g. reuse column('value') or add 'ts') and implement a periodic cleanup
timer that removes/stales entries before they exhaust capacity. Ensure you
reference $hostnames, ->set(), column('value'), create() and the $domains sizing
as you make the change.

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@app/http.php`:
- Around line 47-49: The Swoole\Table instance $hostnames has no eviction and
will silently drop inserts when full; fix by (1) handling failed inserts from
$hostnames->set(...) — check its boolean return and log/metric on false — and
(2) either increase the table size passed to new Table(...) or implement an
explicit eviction strategy (e.g., maintain a rolling key via an atomic counter
and overwrite old entries) so entries aren't silently lost; update any code that
writes to $hostnames to use the new check and eviction approach (symbols:
$hostnames, Table::TYPE_INT, $hostnames->set, create).

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@app/http.php`:
- Around line 47-52: Summary: The shared $hostnames Table is correctly created
and registered via Http::setResource and requires no code changes; keep the
current DI registration for 'domains' and 'hostnames' as-is. Leave the Table
instantiation (new Table(100_000)), column definition (column('value',
Table::TYPE_INT, 1)), and Http::setResource('hostnames', fn () => $hostnames)
unchanged; ensure the previously flagged no-eviction concern for $hostnames is
tracked/fixed elsewhere (confirm mitigation or add ticket) and run the
worker/task integration tests to validate resource access.

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@app/controllers/general.php`:
- Around line 1078-1090: The cache key is inconsistent: exists(md5($hostname))
uses the raw request value while set(md5($domain->get())) uses the normalized
Domain::get(), so cache misses always occur; fix by normalizing once and using
the same key for both checks and writes (e.g., compute $normalizedHost =
$domain->get() or $domain->normalize() after creating Domain from
$request->getHostname(), then use
$certifiedDomains->exists(md5($normalizedHost)) and
$certifiedDomains->set(md5($normalizedHost), ...) and update the later write at
the location referenced (line ~1167) to also use md5($normalizedHost)).

In `@app/http.php`:
- Around line 43-52: The Swoole Table sizing/eviction issue: increase the tables
from 100_000 to a larger capacity (e.g., 1_000_000) when constructing
riskyDomains and certifiedDomains, and add handling around every Table::set(...)
call that writes into these tables to check the boolean return value and log a
warning/error (include the table name and key being inserted) when set() returns
false so we detect a full table; optionally also add instrumentation
(counter/gauge) or a periodic cleanup/TLL-like strategy if appropriate.
Reference the Table instances riskyDomains and certifiedDomains and the places
where you call Table::set(...) to add the return-value check and logging.

---

Nitpick comments:
In `@app/controllers/general.php`:
- Around line 1098-1101: When the branch checking !$in_array($domain->get(),
$platformHostnames) returns early, add a cache entry for this non-platform
domain so subsequent requests skip re-parsing/validation; before the return,
write a cache key (e.g. "non_platform_domain:".$domain->get()) with a reasonable
TTL (e.g. 1h) using the existing caching service used elsewhere in this
controller, and ensure you only cache valid, non-test domains (the same
condition that triggers the return) to avoid caching test/invalid entries.