Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

src/Appwrite/Messaging/Adapter/Realtime.php (1)

514-519: ⚠️ Potential issue | 🟠 Major

Deduplicate merged channels before returning payload.

This merge still produces duplicates (notably rows) because it reindexes with array_values(...) but does not unique-filter the merged list.

🛠️ Proposed fix

-                    $channels = array_values(array_merge(
+                    $channels = array_values(array_unique(array_merge(
                         self::getDatabaseChannels('legacy', $database->getId(), $resourceId, $payload->getId(), 'databases'),
                         self::getDatabaseChannels('tablesdb', $database->getId(), $resourceId, $payload->getId(), 'databases'),
                         self::getDatabaseChannels('tablesdb', $database->getId(), $resourceId, $payload->getId())
-                    ));
+                    )));

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Messaging/Adapter/Realtime.php` around lines 514 - 519, The
merged channel list assigned to $channels from multiple calls to
self::getDatabaseChannels(...) can contain duplicate entries (e.g., "rows");
after merging, filter duplicates before reindexing by applying a uniqueness
filter (e.g., array_unique) to the combined array, then call array_values to
reindex so $channels contains only distinct channel names; update the $channels
assignment where the three getDatabaseChannels calls are merged.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

tests/e2e/Services/Realtime/RealtimeCustomClientTest.php (2)

126-127: Remove redundant list assertion in the same block.

assertIsList() already validates this; keeping both checks adds noise.

♻️ Proposed cleanup

-        $this->assertIsList($response['data']['channels']);
-        $this->assertTrue(array_is_list($response['data']['channels']));
+        $this->assertIsList($response['data']['channels']);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/e2e/Services/Realtime/RealtimeCustomClientTest.php` around lines 126 -
127, The test contains a redundant assertion: keep the built-in PHPUnit
assertion $this->assertIsList($response['data']['channels']) and remove the
duplicate check that calls array_is_list($response['data']['channels']) inside
$this->assertTrue(...); update the RealtimeCustomClientTest test method to
delete the line with $this->assertTrue(array_is_list(...)) so only
$this->assertIsList(...) remains.

---

823-824: Consider replacing repeated 8 with a named test constant.

The mirrored-channel count is asserted many times; a constant will make updates safer and easier.

♻️ Proposed refactor

 class RealtimeCustomClientTest extends Scope
 {
+    private const MIRRORED_DB_CHANNEL_COUNT = 8;

-        $this->assertCount(8, $response['data']['channels']);
+        $this->assertCount(self::MIRRORED_DB_CHANNEL_COUNT, $response['data']['channels']);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/e2e/Services/Realtime/RealtimeCustomClientTest.php` around lines 823 -
824, The test uses the magic number 8 repeatedly when asserting the mirrored
channel count; add a named test constant (e.g., EXPECTED_MIRRORED_CHANNEL_COUNT)
to the test class and replace literal usages of 8 in assertions like
$this->assertCount(8, $response['data']['channels']) and any other identical
assertions with self::EXPECTED_MIRRORED_CHANNEL_COUNT to centralize the value
and make future updates safer.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro