Reapply SMTP auth fix from PR #10939 onto 1.8.x#11441
Closed
Conversation
Copilot
AI
changed the title
[WIP] Reapply changes from pull request 10939 to branch 1.8.x
Reapply SMTP auth fix from PR #10939 onto 1.8.x
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SMTP auth fix from PR #10939 had disappeared from the 1.8.x branch. The core issue: PHPMailer's
SMTPAuthwas never set, so authentication was never attempted, allowing invalid credentials to be saved silently.Changes
app/controllers/api/projects.php: Set$mail->SMTPAuthbased on whether credentials are provided, ensuring authentication is actually validated before saving SMTP config. Error message now surfaces$error->getMessage()directly instead of prepending a redundant prefix.docker-compose.yml: Maildev configured to require authentication viaMAILDEV_INCOMING_USER/MAILDEV_INCOMING_PASS, matching env-sourced credentials..env: Default SMTP credentials (user/password) set to match maildev auth configuration.tests/e2e/Scopes/ProjectCustom.php/ProjectsConsoleClientTest.php: Tests now read SMTP config from environment variables and include an explicit failure case for invalid credentials (expects 400 +"Could not authenticate"in response).🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.