Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request updates two error entries in app/config/errors.php: Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
4e66458 to
3e1d855
Compare
eldadfux
approved these changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/config/errors.php`:
- Around line 169-172: You changed Exception::USER_BLOCKED to return HTTP 403,
so update the corresponding assertions in the AccountCustomClientTest test
class: find the two assertions for the blocked-account flow and the two
assertions for the self-blocked flow and change their expected status from 401
to 403 so the tests match the new Exception::USER_BLOCKED code.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 183124e0-520e-4eec-a9f3-f0e9b73f0a8f
📒 Files selected for processing (2)
app/config/errors.phptests/e2e/General/HooksTest.php
🔄 PHP-Retry SummaryFlaky tests detected across commits: Commit
|
| Test | Retries | Total Time | Details |
|---|---|---|---|
UsageTest::testDatabaseStatsCollectionsAPI |
1 | 10.24s | Logs |
LegacyConsoleClientTest::testEnforceCollectionAndDocumentPermissions |
1 | 240.20s | Logs |
LegacyCustomClientTest::testUpdateAttributeEnum |
1 | 240.11s | Logs |
LegacyCustomClientTest::testEnforceCollectionPermissions |
1 | 240.53s | Logs |
LegacyCustomClientTest::testTimeout |
1 | 240.18s | Logs |
LegacyCustomServerTest::testSpatialRelationshipManyToOne |
1 | 240.20s | Logs |
TablesDBConsoleClientTest::testDecrementAttribute |
1 | 240.15s | Logs |
TablesDBCustomServerTest::testUpdatePermissionsWithEmptyPayload |
1 | 240.37s | Logs |
TablesDBCustomServerTest::testOneToManyRelationship |
1 | 240.13s | Logs |
LegacyTransactionsConsoleClientTest::testCommit |
1 | 240.47s | Logs |
- Update USER_BLOCKED from 401 to 403 and simplify description - Update GENERAL_RESOURCE_BLOCKED from 401 to 403 Rationale: 403 Forbidden is the correct HTTP status for authorization failures where the user is authenticated but not permitted access. 401 Unauthorized is for authentication failures. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Change expected status code from 401 to 403 for USER_BLOCKED errors to match the semantic change in error codes. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
446f75c to
a2ad25a
Compare
✨ Benchmark results
⚡ Benchmark Comparison
|
Update testBlockedAccount and testSelfBlockedAccount to expect 403 instead of 401 for blocked user responses. These were missed in the previous test assertion update. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.