Conversation
Add Rust SDK entry to server platform config, wire up the Rust language class in the SDK generation task, update sdk-generator to dev-rust branch, and create the changelog directory.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis pull request adds support for the Rust SDK to the Appwrite platform. The changes include: registering a new Rust server SDK entry in the configuration with associated metadata (version, repository URLs, and git details), importing and handling the Rust language class in the SDK task processor, and removing an obsolete PHPStan baseline error entry. The modifications follow existing patterns for SDK integration and require no structural or logic changes to the platform's core architecture. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds Rust SDK support to Appwrite by registering the SDK in the platform config, wiring up the Key changes:
Confidence Score: 2/5
Important Files Changed
Reviews (1): Last reviewed commit: "Merge branch '1.9.x' into feat-rust-sdk" | Re-trigger Greptile |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
composer.json (1)
102-102: Use a stable version constraint instead ofdev-rustbranch.The
dev-rustbranch constraint should be temporary. Once the Rust SDK support is merged into the main sdk-generator repository, update this to a stable version (e.g.,1.11.10or*). Branch constraints are fragile and can break unexpectedly if the branch is deleted or renamed.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@composer.json` at line 102, The composer dependency "appwrite/sdk-generator": "dev-rust" is using a branch constraint; update the constraint to a stable version to avoid fragility—replace "dev-rust" with an appropriate released version specifier (for example "1.11.10" or a caret range like "^1.11.10" or "*" if you need to allow any stable release) in the composer.json dependency entry for appwrite/sdk-generator so Composer uses a published tag instead of the dev branch.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@composer.json`:
- Line 102: The composer dependency "appwrite/sdk-generator": "dev-rust" is
using a branch constraint; update the constraint to a stable version to avoid
fragility—replace "dev-rust" with an appropriate released version specifier (for
example "1.11.10" or a caret range like "^1.11.10" or "*" if you need to allow
any stable release) in the composer.json dependency entry for
appwrite/sdk-generator so Composer uses a published tag instead of the dev
branch.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 97c303cf-1aa7-4f38-96d6-0c191f42d237
⛔ Files ignored due to path filters (2)
composer.lockis excluded by!**/*.lockdocs/sdks/rust/CHANGELOG.mdis excluded by!docs/sdks/**
📒 Files selected for processing (3)
app/config/sdks.phpcomposer.jsonsrc/Appwrite/Platform/Tasks/SDKs.php
🔄 PHP-Retry SummaryFlaky tests detected across commits: Commit
|
| Test | Retries | Total Time | Details |
|---|---|---|---|
UsageTest::testFunctionsStats |
1 | 10.14s | Logs |
UsageTest::testPrepareSitesStats |
1 | 8ms | Logs |
Commit ce5d5cf - 3 flaky tests
| Test | Retries | Total Time | Details |
|---|---|---|---|
UsageTest::testFunctionsStats |
1 | 10.14s | Logs |
UsageTest::testPrepareSitesStats |
1 | 7ms | Logs |
TablesDBCustomServerTest::testIncrementAttribute |
1 | 240.47s | Logs |
✨ Benchmark results
⚡ Benchmark Comparison
|
Summary
app/config/sdks.php(beta, dev)Rustlanguage class in SDK generation task (SDKs.php)sdk-generatordependency todev-rustbranchdocs/sdks/rust/CHANGELOG.mdTest plan
docker compose exec appwrite sdks --sdk=rust