AGENTS.md (1)

44-52: Add language specifier to fenced code block.

The code block showing module structure should have a language identifier for consistency and to satisfy markdown linting rules. Since this is a directory structure, use text or plaintext.

📝 Suggested fix

-```
+```text
 Module.php           -- registers all services for the module
 Services/Http.php    -- registers HTTP endpoints
 Services/Workers.php -- registers background workers
 Services/Tasks.php   -- registers CLI tasks
 Http/{Service}/      -- endpoint actions (Create.php, Get.php, Update.php, Delete.php, XList.php)
 Workers/             -- worker implementations
 Tasks/               -- CLI task implementations

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@AGENTS.md` around lines 44 - 52, The fenced code block that lists the module
structure lacks a language specifier; update the opening triple-backtick to
include a plaintext identifier (e.g., ```text) so the block becomes a labeled
plaintext code fence containing the listed lines (Module.php, Services/Http.php,
Services/Workers.php, Services/Tasks.php, Http/{Service}/, Workers/, Tasks/).

src/Appwrite/Platform/Tasks/Install.php (1)

639-646: Swallowing all exceptions from $onComplete may hide legitimate errors.

While silently catching \Throwable prevents completion callbacks from breaking the installation flow, it also suppresses any diagnostic information. Consider logging the exception for debugging purposes.

📝 Suggested improvement

                if ($onComplete) {
                    try {
                        $onComplete();
-                   } catch (\Throwable) {
+                   } catch (\Throwable $e) {
+                       // Log for debugging but don't fail installation
+                       error_log('onComplete callback failed: ' . $e->getMessage());
                    }
                }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Tasks/Install.php` around lines 639 - 646, The current
catch block around $onComplete() swallows all throwables; change it to catch
(\Throwable $e) and log the exception before continuing so errors aren't
hidden—use the existing logger (e.g. $this->logger or the available logging
instance) to call ->error(...) including $e->getMessage() and
$e->getTraceAsString() (or pass $e as context) inside the catch, then continue
without rethrowing to preserve the current flow.

src/Appwrite/Platform/Tasks/Install.php (1)

775-789: Minor: gethostbyname() never returns false.

The function returns the unmodified hostname on failure rather than false. The check $hostIp !== $domain is sufficient.

🔧 Simplified check

 $hostIp = `@gethostbyname`($domain);
 ...
-'hostIp' => ($hostIp !== false && $hostIp !== $domain) ? $hostIp : null,
+'hostIp' => ($hostIp !== $domain) ? $hostIp : null,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Tasks/Install.php` around lines 775 - 789, The check
for DNS resolution uses gethostbyname($domain) which never returns false, so
update the condition that sets 'hostIp' in the payload (in Install.php where
$hostIp is assigned and used) to only test whether $hostIp differs from $domain;
remove the redundant !== false check and set hostIp to null when $hostIp ===
$domain, i.e. replace the current ($hostIp !== false && $hostIp !== $domain)
logic with a single ($hostIp !== $domain) check so unresolved hostnames yield
null.

src/Appwrite/Platform/Tasks/Install.php (2)

775-789: The !== false check is unnecessary for gethostbyname().

PHP's gethostbyname() returns the original hostname string on failure, never false. The check $hostIp !== false is always true.

♻️ Simplified condition

         $hostIp = `@gethostbyname`($domain);
 
         $payload = [
             ...
-            'ip' => ($hostIp !== false && $hostIp !== $domain) ? $hostIp : null,
+            'ip' => ($hostIp !== $domain) ? $hostIp : null,
             ...
         ];

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Tasks/Install.php` around lines 775 - 789, The ip
assignment logic uses gethostbyname($domain) and checks "$hostIp !== false", but
gethostbyname never returns false (it returns the original hostname on failure),
so update the condition that builds the payload 'ip' field in Install::
(variable $hostIp and the payload array) to only check that $hostIp is not equal
to the original $domain (or is a valid IP) — remove the redundant !== false
check and use a single clear test like ($hostIp !== $domain) or PHP's
filter_var($hostIp, FILTER_VALIDATE_IP) to set the 'ip' value or null.

---

639-656: Silently swallowing exceptions in $onComplete may hide lock-release failures.

Per the context, $onComplete contains critical logic including $state->updateGlobalLock(). If the lock update fails, the exception is caught and ignored, potentially leaving the installer in a locked state for subsequent runs.

Consider logging the exception or at least preserving it for debugging:

💡 Proposed enhancement to log swallowed exceptions

                 if ($onComplete) {
                     try {
                         $onComplete();
                     } catch (\Throwable) {
+                        // Lock update or response finalization failed - log for debugging
+                        // Consider: Console::warning('onComplete callback failed: ' . $e->getMessage());
                     }
                 }

The coroutine-wrapped tracking logic is correct — go() is only called when inside a Swoole context (Coroutine::getCid() !== -1), otherwise tracking runs synchronously.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Appwrite/Platform/Tasks/Install.php` around lines 639 - 656, The current
try/catch around invoking the $onComplete callback swallows all exceptions
(which may include failures from $state->updateGlobalLock()), so update the
catch to record the error instead of ignoring it: catch the Throwable as $e and
log it (e.g. via $this->logger->error(...) or a suitable logger/error_log) with
context indicating it occurred in the $onComplete callback and include
$e->getMessage() and stack trace; alternatively rethrow or store the exception
for higher-level handling—locate the invocation of $onComplete in Install.php
and update that try/catch accordingly (leave the coroutine handling and
trackSelfHostedInstall calls unchanged).