Extend Arduino API by introducing a function called digitalToggle.#192
Extend Arduino API by introducing a function called digitalToggle.#192tetex7 wants to merge 5 commits intoarduino:masterfrom
digitalToggle.#192Conversation
a C++ wraper for the digital IO calls
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 13 13
Lines 970 970
=======================================
Hits 929 929
Misses 41 41
☔ View full report in Codecov by Sentry. |
per1234
left a comment
There was a problem hiding this comment.
Hi @tetex7. Thanks so much for your pull request!
the cla bot got problems
I see that you have already signed our Contributor License Agreement (CLA). Unfortunately, the @CLAassistant bot has not been able to validate the pull request.
This is caused by the email address used in your local Git settings not being associated with your GitHub account.
You can see the email address that is being used in the commit metadata here:
Please follow these instructions to resolve the issue:
Hopefully the check will automatically pass once that has been done. If not, please comment here and we will investigate.
|
Hi @tetex7 ☕ 👋 Thank you for your PR. A desire for The Arduino API is the lowest common denominator across the complete Arduino ecosystems. Furthermore the success of Arduino is based in no small part exactly of that very small API ( Cheers, Alex |
|
@per1234 i removed the C++ wrapper for the IO per request |
|
sorry about the trouble it's my first pull request |
digitalToogle.
|
So. I probably should have called this sooner, but there's little change that this API will be added to ArduinoCore-API. Unfortunately we do not have yet a set process of how to add anything to the Arduino language (or API) but I feel it's within my purview to close this PR (and ceasing to pretend that it might be considered eventually). If and when such a process is in place I'll be bringing in your API extension request on your behalf, should you not do it yourself. |
digitalToogle.digitalToggle.
I also add a Toggle call for the Digital IO
and the cla bot got problems