Core library support in the language server.#1065
Merged
g-r-a-n-t merged 1 commit intoargotorg:masterfrom Mar 15, 2025
Merged
Conversation
bea3611 to
97fd1e0
Compare
99d6279 to
0ab6e2f
Compare
sbillig
approved these changes
Mar 15, 2025
Collaborator
sbillig
left a comment
There was a problem hiding this comment.
I'm fine with merging this as-is, but I think we need to be more careful with InputIngot::core (at least when we have multiple ingots in a single program). Each call to InputIngot::core returns a new InputIngot, so if we create two LocalIngotContexts via LocalIngotContext::new, they'll have different instances of the core ingot, and there will be two incompatible instances of the Option type, for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using rust-embed and moved static core setup to
common::input. Atm users get an error when goto selecting something in the core library.