Skip to content

Minor Bug Fixes#1605

Merged
shehzan10 merged 4 commits intoarrayfire:hotfix-3.4.1from
shehzan10:hotfix-3.4.1
Sep 29, 2016
Merged

Minor Bug Fixes#1605
shehzan10 merged 4 commits intoarrayfire:hotfix-3.4.1from
shehzan10:hotfix-3.4.1

Conversation

@shehzan10
Copy link
Copy Markdown
Member

[skip arrayfire ci]

@shehzan10 shehzan10 added the bug label Sep 23, 2016
@shehzan10 shehzan10 added this to the v3.4.1 milestone Sep 23, 2016
s_idx[sid] = s_idx[sid + i];
}
__syncthreads();
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__syncthreads() should go here. This is a block reduction step.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! my bad. i thought i moved it there.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

@pavanky
Copy link
Copy Markdown
Member

pavanky commented Sep 24, 2016

@pavanky
Copy link
Copy Markdown
Member

pavanky commented Sep 25, 2016

Also this.

diff --git a/src/backend/cpu/scan_by_key.cpp b/src/backend/cpu/scan_by_key.cpp
index d00db6c..f176840 100644
--- a/src/backend/cpu/scan_by_key.cpp
+++ b/src/backend/cpu/scan_by_key.cpp
@@ -31,6 +31,7 @@ namespace cpu
         kernel::scan_dim_by_key<op, Ti, Tk, To, 4> func4(inclusive_scan);

         in.eval();
+        key.eval();
         switch (in.ndims()) {
         case 1:
             getQueue().enqueue(func1, out, 0, key, 0, in, 0, dim);

@shehzan10 shehzan10 merged commit b7bff62 into arrayfire:hotfix-3.4.1 Sep 29, 2016
@shehzan10 shehzan10 mentioned this pull request Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants