Make constructors that accept simple types explicit#3259
Merged
umar456 merged 1 commit intoarrayfire:masterfrom Sep 12, 2022
Merged
Make constructors that accept simple types explicit#3259umar456 merged 1 commit intoarrayfire:masterfrom
umar456 merged 1 commit intoarrayfire:masterfrom
Conversation
Some of the ArrayFire constructors that accept the dim_t type are not marked explicit. this allows the initialization of the ArrayFire's array using integer types. For example ``` af::array a = 5 ``` will create an af::array with 5 elements. This is not intended behavior. I have looked into the ABI for this change and it doesn't seem to be affected on GCC. I have to still test this on MSVC. This CAN break some existing code because it does change the API but ArrayFire was never designed with this code in mind.
syurkevi
approved these changes
Jun 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the ArrayFire constructors that accept the dim_t type are not
marked explicit. this allows the initialization of the ArrayFire's array
using integer types.
Description
Some of the ArrayFire constructors that accept the dim_t type are not
marked explicit. this allows the initialization of the ArrayFire's array
using integer types. For example
will create an af::array with 5 elements. This is not intended behavior.
I have looked into the ABI for this change and it doesn't seem to
be affected on GCC. I have to still test this on MSVC. This CAN
break some existing code because it does change the API but ArrayFire
was never designed with this code in mind.
Changes to Users
This change CAN break some user code. The following code will break
af::arrayusing an integer or floatChecklist
[ ] Functions added to unified API[ ] Functions documented