Retain the arrays returned from Features's accessors#68
Merged
9prady9 merged 2 commits intoarrayfire:develfrom Apr 23, 2016
Merged
Retain the arrays returned from Features's accessors#689prady9 merged 2 commits intoarrayfire:develfrom
9prady9 merged 2 commits intoarrayfire:develfrom
Conversation
Member
|
good catch 👍 thank you. |
src/vision/mod.rs
Outdated
| let err_val = $ffi_name(&mut temp as MutAfArray, self.feat as Feat); | ||
| match err_val { | ||
| 0 => Ok(Array::from(temp)), | ||
| 0 => Ok(Array::from_retained(temp)), |
Member
There was a problem hiding this comment.
@mmetcalfe
I don't think we need a new member function for this unless there are more use cases to it. Probably doing just Ok(Array::from(temp).clone()) is enough. Can you please check it and change accordingly.
|
|
||
| let temp_array = Array::from(temp); | ||
| let retained = temp_array.clone(); | ||
| unsafe { mem::forget(temp_array); } |
Contributor
Author
There was a problem hiding this comment.
I just changed the implementation based on your suggestion.
Using mem::forget here feels like a bit of a hack, but doing it this way doesn't require touching other files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, calling accessor methods on a Features object causes a crash due to a double free.
A (reasonably) minimal example of this problem is demonstrated in the following program:
Using the current devel branch of arrayfire-rust (f22a5fb) the program outputs the following:
Un-commenting the unsafe line in the above example prevents the error.
This pull request changes the feat_func_def macro in the vision module to retain the arrays returned from af_get_features_* functions, in the same way that ArrayFire's current c++ implementation does.
With this change applied the output of the above program is as expected: