Merged
Conversation
9prady9
requested changes
Nov 17, 2016
Member
9prady9
left a comment
There was a problem hiding this comment.
Except the change i requested in a separate comment, everything else looks good. Thank you for the contributions!
src/graphics.rs
Outdated
| let xstr = CString::new(xlabel.as_bytes()).unwrap(); | ||
| let ystr = CString::new(ylabel.as_bytes()).unwrap(); | ||
| let zstr = CString::new(zlabel.as_bytes()).unwrap(); | ||
| let cprops = &Cell {row: self.row, col: self.col, title: [0].as_ptr(), cmap: self.cmap}; |
Member
There was a problem hiding this comment.
Can you please use std::ptr::null instead of an static single element slice to get a invalid pointer. Please do similar change in all other places where [0].as_ptr() is being used.
9prady9
approved these changes
Nov 17, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colormaps are not currently working because layout of the
Cellstructure doesn't match its version in arrayfire. Also there are some potential bugs because Rust's non null-terminated strings were passed to C.This pull request fixes this. I also simplified code in graphics.rs where other strings were passed to C.