This repository was archived by the owner on Jan 1, 2024. It is now read-only.
2-minute demo instructions update and skip HTML escape#38
Closed
webandy wants to merge 5 commits intoassaf:masterfrom
webandy:master
Closed
2-minute demo instructions update and skip HTML escape#38webandy wants to merge 5 commits intoassaf:masterfrom webandy:master
webandy wants to merge 5 commits intoassaf:masterfrom
webandy:master
Conversation
…ltiple apps using vanity share a redis.
Contributor
Author
|
Hi Assaf. I added some more stuff. If you like some of it you might want to cherry pick. What I added: 4d540e3: adds parent application name to redis key. added a test for this. haven't put this into production yet. 7501456: added a failing test case for a current issue where the "collecting" property does not seem to be read from vanity.yml. There is a Github issue for this. |
Owner
|
Thanks, merged the documentation changes and used failing test case to fix the underlying issue. Don't want to change the namespace (again). Not sure what the template changes to and why each in a <%= block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Assaf. There are two commits here. I tried to segment the 2-minute demo instructions into separate instructions for Rails 2.x and Rails 3.x. I also added some additional instructions at some points that tripped me up getting set up initially, that I'm suggesting as feedback, but I leave it up to you whether or not you want to include them. My feeling is that the "2-minute demo" instructions should be bulletproof. Personally I love these kinds of short getting started instructions, I'll create a sample app, run through them, and it gives a good idea of how maintained the code is. I think some instructions are missing from the 2-minute demo now to make this possible, so I tried to provide the minimum that I missed.
Then the other thing is a suggested patch to use "each" instead of "map" in one of the partials for the vanity dashboard. I just hacked that in locally for myself (might be something better to do here) so that the html was not escaped in this case. For some reason your "do not html escape" code (or "raw" for Rails 3) didn't work inside the block of map(), but does work inside the block of each(). Must be a Ruby thing I don't really understand.
Thanks!