TST: lift xfail from tests fixed upstream in matplotlib#11315
TST: lift xfail from tests fixed upstream in matplotlib#11315pllim merged 2 commits intoastropy:masterfrom
Conversation
|
Please note that this is a draft and includes a temporary change to tox.ini to try building against @tacaswell's branch. |
|
Thanks! I converted this PR to draft status for now, as indicated. |
|
Re: Not sure what happened but seems like you reverted too much? All you need is to delete the lines added in the final diff of https://github.com/astropy/astropy/pull/11292/files |
|
The tests were failing, and I noticed that @tacaswell's branch was well behind master, so I thought I would try reverting more. I'll go back to just removing those two xfail markers, but then I'll need to rebase his branch in order to test it. |
dc83356 to
c577395
Compare
|
It's failing with a whole bunch of 404 errors when it tries to download baseline images... Is some piece of infrastructure down at the moment? |
This comment has been minimized.
This comment has been minimized.
|
Does matplotlib use setuptools_scm now? If so, maybe because your fork doesn't have the tags necessary to build the correct version number? |
|
Interesting thought. I pushed the tags to my fork, then try again. |
02a37ca to
250ea72
Compare
|
mpldev is green! 👏 |
|
Woot! OK, I'll report back to Matplotlib that this fix will work for us. |
No, but we are working on switching: matplotlib/matplotlib#18971 currently we use versioneer. I re-worked my mpl PR, is there an easy way to re-trigger this CI work? |
You mean astropy's? Please rebase against master and push all of matplotlib's version tags to your fork. Then I can trigger it. |
07e6bea to
d056470
Compare
|
Done. I have to pushed tags to my fork in a very long time (it pushed 1.5.2 on 🤣 ) . |
|
I triggered a build a little while ago, before you had pushed the latest tag, by pushing your branch to my fork. It's still passing :-) |
961226c to
f2163d3
Compare
|
matplotlib/matplotlib#19438 is in now, so this is ready for review. |
|
Thanks! Remote failure unrelated and you can ignore coverage complain. Before I get this in, can you please remove |
pllim
left a comment
There was a problem hiding this comment.
Perfect. Thanks!
I'll cancel Actions as it is not needed. As soon as mpldev passes, I will merge. 😄
Lift xfail from tests fixed upstream in matplotlib.
Fixes #11267.