Skip to content

Restrict matplotlib version check for failing test#12052

Merged
pllim merged 1 commit intoastropy:mainfrom
nstarman:tst_12050
Aug 13, 2021
Merged

Restrict matplotlib version check for failing test#12052
pllim merged 1 commit intoastropy:mainfrom
nstarman:tst_12050

Conversation

@nstarman
Copy link
Copy Markdown
Member

@nstarman nstarman commented Aug 13, 2021 •
edited by pllim
Loading

Signed-off-by: Nathaniel Starkman (@nstarman) [email protected]

Restrict the version check to the relevant matplotlib version.

Fixes #12050

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@nstarman nstarman added Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed labels Aug 13, 2021
@nstarman nstarman added this to the v5.0 milestone Aug 13, 2021
@nstarman nstarman requested a review from pllim August 13, 2021 17:47
@pllim
Copy link
Copy Markdown
Member

pllim commented Aug 13, 2021

That is so weird. I don't understand why this is happening... Did they re-release 3.4.2 ?! How can the behavior change like this?

@pllim
Copy link
Copy Markdown
Member

pllim commented Aug 13, 2021

Unless this somehow only affects the dev version... There is a vague memory of us not able to use dev tag for their version check. Which means this is going to come back and haunt us after every matplotlib release. 😢

@pllim
Copy link
Copy Markdown
Member

pllim commented Aug 13, 2021

Not sure about backporting... but doesn't hurt? #11717 was milestoned for 4.3.

@pllim pllim modified the milestones: v5.0, v4.3.2 Aug 13, 2021
@pllim pllim added backport-v4.3.x testing and removed Affects-dev PRs and issues that do not impact an existing Astropy release labels Aug 13, 2021
pllim
pllim approved these changes Aug 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😸

@pllim pllim merged commit ace7db5 into astropy:main Aug 13, 2021
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Aug 13, 2021
@pllim @meeseeksmachine
Backport PR astropy#12052: Restrict matplotlib version check for fail…
c4b455f 
…ing test
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 13, 2021
Closed
@pllim pllim mentioned this pull request Aug 13, 2021
Merged
9 tasks
@nstarman nstarman deleted the tst_12050 branch August 13, 2021 19:15
@nstarman
Copy link
Copy Markdown
Member Author

nstarman commented Aug 13, 2021

Which means this is going to come back and haunt us after every matplotlib release. 😢

Perhaps a better fix would be to target the dev tag? Or check if it's a released version?

@pllim
Copy link
Copy Markdown
Member

pllim commented Aug 13, 2021

@nstarman , that is worth looking into. The last time we had to do this, we couldn't due to matplotlib/matplotlib#19419 but I see that issue is now closed.

This was referenced Aug 13, 2021
Closed
Merged
astrofrog pushed a commit that referenced this pull request Aug 18, 2021
@pllim @astrofrog
Merge pull request #12052 from nstarman/tst_12050
c13fd8a 
Restrict matplotlib version check for failing test
@astrofrog astrofrog modified the milestones: v4.3.2, v4.0.6 Aug 19, 2021
@astrofrog
Copy link
Copy Markdown
Member

astrofrog commented Aug 19, 2021

I had to backport this to LTS in the end so updating the milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

no-changelog-entry-needed testing visualization.wcsaxes

Projects

None yet

Milestone

v4.0.6

Development

Successfully merging this pull request may close these issues.

TST: test_no_numpy_warnings failed in main branch CI due to matplotlib 3.4.3

3 participants

@nstarman @pllim @astrofrog