Skip to content

MAINT: minor cleanup of duplicate check#18497

Merged
pllim merged 1 commit intoastropy:mainfrom
bsipocz:MAINT_minor_cleanup
Aug 4, 2025
Merged

MAINT: minor cleanup of duplicate check#18497
pllim merged 1 commit intoastropy:mainfrom
bsipocz:MAINT_minor_cleanup

Conversation

@bsipocz
Copy link
Copy Markdown
Member

@bsipocz bsipocz commented Aug 4, 2025

I was digging the source code to find the answer for a review question. I didn't find it but cleaned up some inconsistencies.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 4, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does look like a duplicate. Weird though the message is slightly different and they were added at the same time by @taldcroft back in #9857 . Thanks for the clean-up!

@pllim pllim added this to the v7.1.1 milestone Aug 4, 2025
@pllim pllim merged commit f95bde9 into astropy:main Aug 4, 2025
48 of 49 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Aug 4, 2025
pllim added a commit that referenced this pull request Aug 4, 2025
…497-on-v7.1.x

Backport PR #18497 on branch v7.1.x (MAINT: minor cleanup of duplicate check)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants