MAINT: minor cleanup of duplicate check#18497
Merged
pllim merged 1 commit intoastropy:mainfrom Aug 4, 2025
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
pllim
approved these changes
Aug 4, 2025
Member
pllim
left a comment
There was a problem hiding this comment.
Does look like a duplicate. Weird though the message is slightly different and they were added at the same time by @taldcroft back in #9857 . Thanks for the clean-up!
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Aug 4, 2025
pllim
added a commit
that referenced
this pull request
Aug 4, 2025
…497-on-v7.1.x Backport PR #18497 on branch v7.1.x (MAINT: minor cleanup of duplicate check)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was digging the source code to find the answer for a review question. I didn't find it but cleaned up some inconsistencies.