MAINT: remove xfail from passing test #2425
Merged
bsipocz merged 1 commit intoastropy:mainfrom Jun 15, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, 4 remote alma tests are failing, one of them because it is passing as opposed to its xfail mark.
The other three are a different case, locally and on CI I see certificate issues like the one below. One puzzling question is why the tests use the noa.ac.jp mirror, as I recall we kind of hard wired the ESO server not long ago.
Maybe @keflavich or @andamian could have a look? (I suppose the first failure just requires to rework the test, or maybe even removing it as its name suggests that it served as testing the documentation (test_doc_example), however now we have doctest running on the narrative docs.