Merged
Conversation
Member
Author
|
Nope does not appear to work. |
Comment on lines
313
to
318
| if filename is None: | ||
| filename = item.name + '.' + extension | ||
| filename = item.function + '.' + extension | ||
| if not single_reference: | ||
| filename = filename.replace('[', '_').replace(']', '_') | ||
| filename = filename.replace('_.' + extension, '.' + extension) |
Member
There was a problem hiding this comment.
I think this should work:
if filename is None:
if single_reference:
filename = item.function + '.' + extension
else:
filename = item.name + '.' + extension
filename = filename.replace('[', '_').replace(']', '_')
filename = filename.replace('_.' + extension, '.' + extension)
Member
Author
There was a problem hiding this comment.
Ah, thanks! I updated the patch and added you as co-author of the commit.
Co-authored-by: Conor MacBride <[email protected]>
8d4086a to
bb77553
Compare
Member
Author
|
Yay, CI is green now. Thanks! I have no expertise nor interest to add a unit test but @astrofrog is welcome to push to my branch if he wants a test. 😉 |
Member
|
I've added a regression test, which unfortunately shows that the fix here doesn't work |
Member
|
@ConorMacBride - for some reason the function name is ending up being |
2eba80d to
86e919e
Compare
Member
|
Ok I got it to work, it was |
astrofrog
approved these changes
Nov 27, 2023
Member
Author
|
Thanks, @astrofrog ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #42