Fix horizontal scrolling on Windows by using MOUSEEVENTF_HWHEEL#948
Open
PekingSpades wants to merge 1 commit intoasweigart:masterfrom
Open
Fix horizontal scrolling on Windows by using MOUSEEVENTF_HWHEEL#948PekingSpades wants to merge 1 commit intoasweigart:masterfrom
PekingSpades wants to merge 1 commit intoasweigart:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
hscroll()function on Windows by usingMOUSEEVENTF_HWHEELinstead ofMOUSEEVENTF_WHEEL.The previous implementation of
_hscroll()in_pyautogui_win.pysimply called_scroll(), which usesMOUSEEVENTF_WHEEL(vertical scroll event). This caused horizontal scrolling to behave exactly like vertical scrolling.Now
_hscroll()properly usesMOUSEEVENTF_HWHEEL(0x01000) to send horizontal scroll events as documented in the Windows API.Changes
_hscroll()function inpyautogui/_pyautogui_win.pyto useMOUSEEVENTF_HWHEELflag_scroll()implementation)Related Issues
Related PRs
Test Plan
pyautogui.hscroll(3)scrolls right on Windowspyautogui.hscroll(-3)scrolls left on Windowspyautogui.scroll()andpyautogui.vscroll()still work correctly