Skip to content

Prep work for query/request parameter refactor#425

Merged
Blacksmoke16 merged 7 commits intomasterfrom
resolver-annotation-refactor
Aug 1, 2024
Merged

Prep work for query/request parameter refactor#425
Blacksmoke16 merged 7 commits intomasterfrom
resolver-annotation-refactor

Conversation

@Blacksmoke16
Copy link
Copy Markdown
Member

@Blacksmoke16 Blacksmoke16 commented Jun 16, 2024

Context

Prepares for #418 by addressing my thoughts in the latest comment. Sets things up well for the next pass to actually implement some of the resolver/annotation logic.

Changelog

  • Breaking: Make ATHR::Interface.configuration macro no longer scoped to resolver namespace
    • If defining the annotation in a different namespace, prefix it with :: and use the FQN
  • Breaking: Rename ATHR::RequestBody::Extract to ATHA::MapRequestBody
  • Breaking: Rename ATHR::Time::Format to ATHA::MapTime

@Blacksmoke16
Copy link
Copy Markdown
Member Author

This is blocked until Crystal 1.13 as it requires crystal-lang/crystal#14490 for the annotations to be defined/resolve correctly.

@Blacksmoke16 Blacksmoke16 marked this pull request as draft June 16, 2024 16:48
@Blacksmoke16 Blacksmoke16 marked this pull request as ready for review July 11, 2024 20:46
@Blacksmoke16 Blacksmoke16 merged commit ea68da6 into master Aug 1, 2024
@Blacksmoke16 Blacksmoke16 deleted the resolver-annotation-refactor branch August 1, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking component:framework kind:enhancement New functionality to an existing feature

Development

Successfully merging this pull request may close these issues.

1 participant