Skip to content

Additional RequestBody annotation properties#486

Merged
Blacksmoke16 merged 5 commits intomasterfrom
additional-map-options
Dec 15, 2024
Merged

Additional RequestBody annotation properties#486
Blacksmoke16 merged 5 commits intomasterfrom
additional-map-options

Conversation

@Blacksmoke16
Copy link
Copy Markdown
Member

@Blacksmoke16 Blacksmoke16 commented Dec 15, 2024

Context

Enhances the RequestBody resolver by allowing some data to flow thru to the underlying implementation via the annotation. This should ultimately make them a bit more flexible.

Changelog

  • Add #validation_groups to ATHA::MapRequestBody and ATHA::MapQueryString
  • Add #accept_formats to ATHA::MapRequestBody
  • Improve docs to call out the resolver can handle form data and query strings
  • Hide ATH::Routing namespace from docs

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@Blacksmoke16 Blacksmoke16 added component:framework kind:enhancement New functionality to an existing feature labels Dec 15, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
compiled 8.14% <0.00%> (-0.01%) ⬇️
unit 92.77% <100.00%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 98.18% <ø> (-1.82%) ⬇️
console 92.61% <ø> (-0.36%) ⬇️
dependency_injection 64.28% <ø> (-35.72%) ⬇️
dotenv 96.80% <ø> (ø)
event_dispatcher 82.75% <ø> (-8.39%) ⬇️
framework 94.27% <100.00%> (-0.38%) ⬇️
image_size 95.03% <ø> (ø)
mercure 93.37% <ø> (ø)
negotiation 97.69% <ø> (ø)
routing 92.96% <ø> (-1.02%) ⬇️
serializer 87.23% <ø> (-4.70%) ⬇️
spec 93.54% <ø> (-6.46%) ⬇️
validator 92.37% <ø> (-0.63%) ⬇️

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 merged commit f89e95e into master Dec 15, 2024
@Blacksmoke16 Blacksmoke16 deleted the additional-map-options branch December 15, 2024 15:08
PallasAthenaie pushed a commit to athena-framework/framework that referenced this pull request Dec 15, 2024
…na#486)

* Improve docs to call out the `RequestBody` resolver can handle form data and query strings
* Hide `ATH::Routing` namespace from docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant