Skip to content

Leverage new AMIME::Types type#545

Merged
Blacksmoke16 merged 3 commits intomasterfrom
better-mime-validation
Jun 12, 2025
Merged

Leverage new AMIME::Types type#545
Blacksmoke16 merged 3 commits intomasterfrom
better-mime-validation

Conversation

@Blacksmoke16
Copy link
Copy Markdown
Member

@Blacksmoke16 Blacksmoke16 commented Jun 8, 2025

Context

Leverage the new capabilities of athena-mime from #534 within the validator and framework components

Changelog

  • Leverage mime component for more robust AVD::Constraints::File MIME type validation
  • Leverage mime component within ATH::BinaryFileResponse

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@Blacksmoke16 Blacksmoke16 added component:validator kind:enhancement New functionality to an existing feature labels Jun 8, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Flag Coverage Δ
compiled 28.11% <0.00%> (ø)
unit 97.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 100.00% <ø> (ø)
console 97.14% <ø> (ø)
dependency_injection 97.98% <ø> (ø)
dotenv 98.58% <ø> (ø)
event_dispatcher 95.46% <ø> (ø)
framework 98.14% <100.00%> (ø)
image_size 96.64% <ø> (ø)
mercure 95.02% <ø> (ø)
mime 99.42% <ø> (ø)
negotiation 97.94% <ø> (ø)
routing 98.40% <ø> (ø)
serializer 96.54% <ø> (ø)
spec 96.68% <ø> (ø)
validator 95.85% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 changed the title More robust AVD::Constraints::File MIME type validation Leverage new AMIME::Types type Jun 8, 2025
@Blacksmoke16 Blacksmoke16 merged commit ebdb367 into master Jun 12, 2025
14 checks passed
@Blacksmoke16 Blacksmoke16 deleted the better-mime-validation branch June 12, 2025 02:56
PallasAthenaie pushed a commit to athena-framework/framework that referenced this pull request Jun 12, 2025
* Leverage `mime` component for more robust `AVD::Constraints::File` MIME type validation
* Leverage `mime` component within `ATH::BinaryFileResponse`
PallasAthenaie pushed a commit to athena-framework/validator that referenced this pull request Jun 12, 2025
* Leverage `mime` component for more robust `AVD::Constraints::File` MIME type validation
* Leverage `mime` component within `ATH::BinaryFileResponse`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant