Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add support for Python3 parameter annotations#84

Closed
corylation wants to merge 1 commit intoatom:masterfrom
corylation:cj-tweaks
Closed

Add support for Python3 parameter annotations#84
corylation wants to merge 1 commit intoatom:masterfrom
corylation:cj-tweaks

Conversation

@corylation
Copy link
Copy Markdown
Contributor

Added a small regex tweak for the grammar to handle annotations, turning this:

wrong

into this:

right

(Note that the variable name "a" is highlighted rather than the type "string" in the function definition)

@jamesob
Copy link
Copy Markdown

jamesob commented Aug 14, 2015

+1

@thomasjo
Copy link
Copy Markdown
Contributor

This looks good to me, but would be nice to have another pair of 👀 on this /cc @atom/feedback

@thomasjo
Copy link
Copy Markdown
Contributor

@corylation It would be awesome if you could add a test for this addition, to guard against future regressions.

@berdario
Copy link
Copy Markdown
Contributor

@thomasjo
If someone wanted to add a test for you, where should it be done?
In the root of the repo there's only:

  • grammars
  • settings
  • snippets
  • spec

There doesn't seem to be any test anywhere

@lee-dohm
Copy link
Copy Markdown
Contributor

@berdario spec is short for "test specifications".

@berdario
Copy link
Copy Markdown
Contributor

Uhm, this project needs documentation

I found that I can run the tests with apm test
The grammar/tokenizer seems clear, but for plenty of other things isn't clear where they are defined

Anyhow, I found that this pull request is now causing the tests to fail, and by looking at the change in the regexp I have no idea how that could have ever worked

I opened another PR, but it needs some work

@pwaller
Copy link
Copy Markdown

pwaller commented Jun 4, 2016

Ping.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants