Add support for Python3 parameter annotations#84
Add support for Python3 parameter annotations#84corylation wants to merge 1 commit intoatom:masterfrom corylation:cj-tweaks
Conversation
|
+1 |
|
This looks good to me, but would be nice to have another pair of 👀 on this /cc @atom/feedback |
|
@corylation It would be awesome if you could add a test for this addition, to guard against future regressions. |
|
@thomasjo
There doesn't seem to be any test anywhere |
|
@berdario |
|
Uhm, this project needs documentation I found that I can run the tests with Anyhow, I found that this pull request is now causing the tests to fail, and by looking at the change in the regexp I have no idea how that could have ever worked I opened another PR, but it needs some work |
|
Ping. |
Added a small regex tweak for the grammar to handle annotations, turning this:
into this:
(Note that the variable name "a" is highlighted rather than the type "string" in the function definition)