Skip to content

Remove confusing reference to branch name#12

Merged
gkwang merged 1 commit intoauth0:masterfrom
jsoref:default-branch
Aug 18, 2022
Merged

Remove confusing reference to branch name#12
gkwang merged 1 commit intoauth0:masterfrom
jsoref:default-branch

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Aug 18, 2022

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Some auth0 repositories use master as the default branch, e.g.:

Others use main, e.g.:

Mentioning master in a generic template that's shared between both kinds of repositories results in some pretty confusing messaging.

Afaict, the text is trying to mean the default branch, so instead of writing master, this PR changes the prose to match the intention.

Testing

I've looked at the wording.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

Copy link
Copy Markdown
Contributor

@gkwang gkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@gkwang gkwang merged commit feb5ec8 into auth0:master Aug 18, 2022
@jsoref jsoref deleted the default-branch branch August 18, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants