Generate authorize URL without calling it#131
Closed
CDyWeb wants to merge 5 commits intoauth0:masterfrom
Closed
Conversation
joshcanhelp
suggested changes
Oct 22, 2018
Contributor
joshcanhelp
left a comment
There was a problem hiding this comment.
Thank you for the contribution here!
| def __init__(self, domain): | ||
| self.domain = domain | ||
|
|
||
| def get_authorize_url(self, client_id, audience=None, state=None, redirect_uri=None, |
Contributor
There was a problem hiding this comment.
if you're going to create a method like this, it would make more sense to call it in authorize below instead of having the logic in two places.
| 'state': state, | ||
| 'redirect_uri': redirect_uri | ||
| } | ||
| query = urlencode(params, doseq=True, quote_via=quote_via) \ |
Contributor
There was a problem hiding this comment.
Can you provide a bit of explanation on why this is necessary?
Contributor
|
@CDyWeb - I still like what you're doing here but we still need some work before we can get this in. It's still eligible for Hacktoberfest if we can merge it in soon but we'll need your response and fixes. |
Contributor
|
Closed, no response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#119
#Hacktoberfest