Skip to content

add string key to materialize cursor#115

Merged
ecordell merged 1 commit intoauthzed:mainfrom
ecordell:matcursor
Aug 16, 2024
Merged

add string key to materialize cursor#115
ecordell merged 1 commit intoauthzed:mainfrom
ecordell:matcursor

Conversation

@ecordell
Copy link
Copy Markdown
Contributor

to support backends that can directly index instead of using an offset

to support backends that can directly index instead of using an offset
Copy link
Copy Markdown

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any scenarios where using starting_key might lead to unexpected performance/behaviour? (while still being a better option than iterating through the whole set)

@ecordell
Copy link
Copy Markdown
Contributor Author

are there any scenarios where using starting_key might lead to unexpected performance/behaviour? (while still being a better option than iterating through the whole set)

The cursor is always something that the server first sends to the client, and the client then uses for a subsequent request. It's not a client-controlled field (or if a client does modify it, we don't care about supporting the changes they make).

@ecordell ecordell merged commit 8dca579 into authzed:main Aug 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants