Skip to content

Add support for relationship expiration in the API#125

Merged
josephschorr merged 1 commit intoauthzed:mainfrom
josephschorr:rel-expiration-api
Nov 26, 2024
Merged

Add support for relationship expiration in the API#125
josephschorr merged 1 commit intoauthzed:mainfrom
josephschorr:rel-expiration-api

Conversation

@josephschorr
Copy link
Copy Markdown
Member

No description provided.

@josephschorr josephschorr force-pushed the rel-expiration-api branch 2 times, most recently from 05b34c2 to f2d2a8d Compare November 26, 2024 20:27
Copy link
Copy Markdown
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr josephschorr merged commit 0aa4ec4 into authzed:main Nov 26, 2024
@josephschorr josephschorr deleted the rel-expiration-api branch November 26, 2024 20:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024

// optional_expires_at is the time at which at least one of the relationships used to
// compute this result, expires (if any). This is *not* related to the caching window.
google.protobuf.Timestamp optional_expires_at = 5;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we add this to the proto? i'm checking SpiceDB code and we're never setting this field (or the one in the file above)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can i remove it @josephschorr ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants