Add support to Watch all object types #13
Merged
josephschorr merged 1 commit intoauthzed:mainfrom Nov 8, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes herein add support to the v1.WatchService.Watch API that allows for a client to watch for changes optionally filtered by one or more object types. If the
optional_object_typesfield is not specified by the client then the intention is to start a watch over all object types.These changes are to support the work that in underway in authzed/spicedb#255 and authzed/spicedb#263 and as proposed in the new LookupWatch API that is under active discussion and development in authzed/spicedb#207.
I recognize these changes are breaking, so I'm open to alternatives, but seeing as there is not yet a v1.WatchService.Watch API implementation (it is under active PR as referenced above) I don't these these breaking changes are impacting clients. Thoughts or alternative suggestions are welcomed 👍
In particular I would like @josephschorr to take a look over these changes and give me any feedback he may have.