Skip to content

Add ability in v1alpha1 schema APIs to use a hash as a precondition#14

Merged
josephschorr merged 1 commit intoauthzed:mainfrom
josephschorr:schema-hash
Nov 9, 2021
Merged

Add ability in v1alpha1 schema APIs to use a hash as a precondition#14
josephschorr merged 1 commit intoauthzed:mainfrom
josephschorr:schema-hash

Conversation

@josephschorr
Copy link
Copy Markdown
Member

No description provided.

@jzelinskie
Copy link
Copy Markdown
Member

Whether or not it is a hash of some form seems like an implementation detail.
This should probably just be called schema_revision and optional_revision_precondition.
For v1, the term "revision" isn't used for ZedTokens/Zookies anymore because they have more specific names (e.g. written_at), so there shouldn't be any confusion.

@josephschorr
Copy link
Copy Markdown
Member Author

@jzelinskie Revision was a bit odd considering the read is for a subset of types, but I guess you can just read it as "latest"

@jzelinskie
Copy link
Copy Markdown
Member

That's an interesting idiosyncrasy for v1alpha1, but it won't be true if we promote these fields to v1.

@josephschorr josephschorr merged commit 262837a into authzed:main Nov 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants