Skip to content

Add a new repeated metadata field for revisions that contain multiple transactions#147

Merged
josephschorr merged 1 commit intoauthzed:mainfrom
josephschorr:watch-revision-metadata
Sep 9, 2025
Merged

Add a new repeated metadata field for revisions that contain multiple transactions#147
josephschorr merged 1 commit intoauthzed:mainfrom
josephschorr:watch-revision-metadata

Conversation

@josephschorr
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not do:

 repeated google.protobuf.Struct optional_transaction_metadata = 3;

?

I believe this change is wire-compatible

@barakmich
Copy link
Copy Markdown

It ought to be wire compatible, but it's worth testing first

https://protobuf.dev/programming-guides/proto3/#conditionally-safe-changes

@josephschorr
Copy link
Copy Markdown
Member Author

It ought to be wire compatible, but it's worth testing first

https://protobuf.dev/programming-guides/proto3/#conditionally-safe-changes

Its wire compatible but will break all the generated clients

@josephschorr josephschorr merged commit eaf5006 into authzed:main Sep 9, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants